summaryrefslogtreecommitdiff
path: root/lib/Analysis/BranchProbabilityInfo.cpp
diff options
context:
space:
mode:
authorChandler Carruth <chandlerc@gmail.com>2011-12-22 09:26:37 +0000
committerChandler Carruth <chandlerc@gmail.com>2011-12-22 09:26:37 +0000
commit51f40a725b4d0bb9ee7a59edc3d2b2392ae9e852 (patch)
tree61209f88fe8dff642f154e81bb0ff948776bd076 /lib/Analysis/BranchProbabilityInfo.cpp
parent3963d617b3709c510003ac816fb42f28539fc62b (diff)
downloadllvm-51f40a725b4d0bb9ee7a59edc3d2b2392ae9e852.tar.gz
llvm-51f40a725b4d0bb9ee7a59edc3d2b2392ae9e852.tar.bz2
llvm-51f40a725b4d0bb9ee7a59edc3d2b2392ae9e852.tar.xz
Make the unreachable probability much much heavier. The previous
probability wouldn't be considered "hot" in some weird loop structures or other compounding probability patterns. This makes it much harder to confuse, but isn't really a principled fix. I'd actually like it if we could model a zero probability, as it would make this much easier to reason about. Suggestions for how to do this better are welcome. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@147142 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/BranchProbabilityInfo.cpp')
-rw-r--r--lib/Analysis/BranchProbabilityInfo.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/Analysis/BranchProbabilityInfo.cpp b/lib/Analysis/BranchProbabilityInfo.cpp
index f9461c0b85..2730ce6c63 100644
--- a/lib/Analysis/BranchProbabilityInfo.cpp
+++ b/lib/Analysis/BranchProbabilityInfo.cpp
@@ -65,8 +65,9 @@ static const uint32_t UR_TAKEN_WEIGHT = 1;
///
/// This is the weight for a branch not being taken toward a block that
/// terminates (eventually) in unreachable. Such a branch is essentially never
-/// taken.
-static const uint32_t UR_NONTAKEN_WEIGHT = 1023;
+/// taken. Set the weight to an absurdly high value so that nested loops don't
+/// easily subsume it.
+static const uint32_t UR_NONTAKEN_WEIGHT = 1024*1024 - 1;
static const uint32_t PH_TAKEN_WEIGHT = 20;
static const uint32_t PH_NONTAKEN_WEIGHT = 12;