summaryrefslogtreecommitdiff
path: root/lib/CodeGen/StackSlotColoring.cpp
diff options
context:
space:
mode:
authorEvan Cheng <evan.cheng@apple.com>2009-10-18 18:16:27 +0000
committerEvan Cheng <evan.cheng@apple.com>2009-10-18 18:16:27 +0000
commitff89dcb06fbd103373436e2d0ae85f252fae2254 (patch)
treea9c2c0c4ab7512a79f6bd15d41caa381e2cccf7c /lib/CodeGen/StackSlotColoring.cpp
parent20270c909357e5e501cac1f5393430dfacfc57d8 (diff)
downloadllvm-ff89dcb06fbd103373436e2d0ae85f252fae2254.tar.gz
llvm-ff89dcb06fbd103373436e2d0ae85f252fae2254.tar.bz2
llvm-ff89dcb06fbd103373436e2d0ae85f252fae2254.tar.xz
-Revert parts of 84326 and 84411. Distinquishing between fixed and non-fixed
stack slots and giving them different PseudoSourceValue's did not fix the problem of post-alloc scheduling miscompiling llvm itself. - Apply Dan's conservative workaround by assuming any non fixed stack slots can alias other memory locations. This means a load from spill slot #1 cannot move above a store of spill slot #2. - Enable post-alloc scheduling for x86 at optimization leverl Default and above. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@84424 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/StackSlotColoring.cpp')
-rw-r--r--lib/CodeGen/StackSlotColoring.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/CodeGen/StackSlotColoring.cpp b/lib/CodeGen/StackSlotColoring.cpp
index 62b2c49943..fad0808c89 100644
--- a/lib/CodeGen/StackSlotColoring.cpp
+++ b/lib/CodeGen/StackSlotColoring.cpp
@@ -466,10 +466,8 @@ void StackSlotColoring::RewriteInstruction(MachineInstr *MI, int OldFI,
// Update the memory references. This changes the MachineMemOperands
// directly. They may be in use by multiple instructions, however all
// instructions using OldFI are being rewritten to use NewFI.
- const Value *OldSV = MFI->isFixedObjectIndex(OldFI)
- ? PseudoSourceValue::getFixedStack(OldFI) : PseudoSourceValue::getStack();
- const Value *NewSV = MFI->isFixedObjectIndex(NewFI)
- ? PseudoSourceValue::getFixedStack(NewFI) : PseudoSourceValue::getStack();
+ const Value *OldSV = PseudoSourceValue::getFixedStack(OldFI);
+ const Value *NewSV = PseudoSourceValue::getFixedStack(NewFI);
for (MachineInstr::mmo_iterator I = MI->memoperands_begin(),
E = MI->memoperands_end(); I != E; ++I)
if ((*I)->getValue() == OldSV)