diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2011-05-24 03:10:31 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2011-05-24 03:10:31 +0000 |
| commit | e6657980977ed63df8bbd2604c9fefe513ac4126 (patch) | |
| tree | c5296dc06b6653b684e3eefaf6d6f1e0c8f6e58f /lib/CodeGen/TargetLoweringObjectFileImpl.cpp | |
| parent | 10c3e128efc9a2efd28414400827fa8b457def4d (diff) | |
| download | llvm-e6657980977ed63df8bbd2604c9fefe513ac4126.tar.gz llvm-e6657980977ed63df8bbd2604c9fefe513ac4126.tar.bz2 llvm-e6657980977ed63df8bbd2604c9fefe513ac4126.tar.xz | |
Explain FIXME.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@131952 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/TargetLoweringObjectFileImpl.cpp')
| -rw-r--r-- | lib/CodeGen/TargetLoweringObjectFileImpl.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/lib/CodeGen/TargetLoweringObjectFileImpl.cpp b/lib/CodeGen/TargetLoweringObjectFileImpl.cpp index ff88b6f2e9..e9cfe43e6d 100644 --- a/lib/CodeGen/TargetLoweringObjectFileImpl.cpp +++ b/lib/CodeGen/TargetLoweringObjectFileImpl.cpp @@ -225,10 +225,11 @@ void TargetLoweringObjectFileELF::emitPersonalityValue(MCStreamer &Streamer, static SectionKind getELFKindForNamedSection(StringRef Name, SectionKind K) { - // FIXME: Why is this here? Codegen is should not be in the business - // of figuring section flags. If the user wrote section(".eh_frame"), - // we should just pass that to MC which will defer to the assembly - // or use its default if producing an object file. + // N.B.: The defaults used in here are no the same ones used in MC. + // We follow gcc, MC follows gas. For example, given ".section .eh_frame", + // both gas and MC will produce a section with no flags. Given + // section(".eh_frame") gcc will produce + // .section .eh_frame,"a",@progbits if (Name.empty() || Name[0] != '.') return K; // Some lame default implementation based on some magic section names. |