summaryrefslogtreecommitdiff
path: root/lib/Support/Path.cpp
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2013-06-28 10:55:41 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2013-06-28 10:55:41 +0000
commit4157466bdc41173a1ebd777739ea219162ae13e0 (patch)
tree23f5d815cbb708deac0df8be8dff85804accca8c /lib/Support/Path.cpp
parentf49d8fcbd594007ac6f25a1f1f90919221011f97 (diff)
downloadllvm-4157466bdc41173a1ebd777739ea219162ae13e0.tar.gz
llvm-4157466bdc41173a1ebd777739ea219162ae13e0.tar.bz2
llvm-4157466bdc41173a1ebd777739ea219162ae13e0.tar.xz
Improve comment.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185141 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Support/Path.cpp')
-rw-r--r--lib/Support/Path.cpp7
1 files changed, 3 insertions, 4 deletions
diff --git a/lib/Support/Path.cpp b/lib/Support/Path.cpp
index fa03df5a24..5c28c55f26 100644
--- a/lib/Support/Path.cpp
+++ b/lib/Support/Path.cpp
@@ -638,8 +638,7 @@ bool is_relative(const Twine &path) {
namespace fs {
// This is a mkostemps with a different pattern. Unfortunatelly OS X (ond *BSD)
-// don't have it. It might be worth experimenting with mkostemps on systems
-// that have it.
+// don't have it. We should try using mkostemps on systems that have it.
error_code unique_file(const Twine &Model, int &ResultFD,
SmallVectorImpl<char> &ResultPath, bool MakeAbsolute,
unsigned Mode) {
@@ -648,7 +647,7 @@ error_code unique_file(const Twine &Model, int &ResultFD,
}
// This is a mktemp with a differet pattern. We use createUniqueEntity mostly
-// for consistency. It might be worth it experimenting with mktemp.
+// for consistency. We should try using mktemp.
error_code unique_file(const Twine &Model, SmallVectorImpl<char> &ResultPath,
bool MakeAbsolute) {
int Dummy;
@@ -656,7 +655,7 @@ error_code unique_file(const Twine &Model, SmallVectorImpl<char> &ResultPath,
}
// This is a mkdtemp with a different pattern. We use createUniqueEntity mostly
-// for consistency. It might be worth it experimenting with mkdtemp.
+// for consistency. We should try using mkdtemp.
error_code createUniqueDirectory(const Twine &Prefix,
SmallVectorImpl<char> &ResultPath) {
int Dummy;