diff options
| author | Alexey Samsonov <samsonov@google.com> | 2013-02-19 11:35:39 +0000 |
|---|---|---|
| committer | Alexey Samsonov <samsonov@google.com> | 2013-02-19 11:35:39 +0000 |
| commit | 9f306bdc70757d11b6510525938c0d92c5529cc7 (patch) | |
| tree | 941ccd3ecde68d9577026c66925b02a0ae8d46fc /lib/Support/TimeValue.cpp | |
| parent | 6ecccdbb2bf24a011b9c8ecbdd39be5a02269670 (diff) | |
| download | llvm-9f306bdc70757d11b6510525938c0d92c5529cc7.tar.gz llvm-9f306bdc70757d11b6510525938c0d92c5529cc7.tar.bz2 llvm-9f306bdc70757d11b6510525938c0d92c5529cc7.tar.xz | |
Fix initialization-order bug in llvm::Support::TimeValue. TimeValue::now() is explicitly called during module initialization of lib/Support/Process.cpp. It reads the field of global object PosixZeroTime, which is not guaranteed to be initialized at this point. Found by AddressSanitizer with -fsanitize=init-order option.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@175509 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Support/TimeValue.cpp')
| -rw-r--r-- | lib/Support/TimeValue.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/lib/Support/TimeValue.cpp b/lib/Support/TimeValue.cpp index 1a0f7bc363..bd8af174bc 100644 --- a/lib/Support/TimeValue.cpp +++ b/lib/Support/TimeValue.cpp @@ -17,11 +17,16 @@ namespace llvm { using namespace sys; +const TimeValue::SecondsType + TimeValue::PosixZeroTimeSeconds = -946684800; +const TimeValue::SecondsType + TimeValue::Win32ZeroTimeSeconds = -12591158400ULL; + const TimeValue TimeValue::MinTime = TimeValue ( INT64_MIN,0 ); const TimeValue TimeValue::MaxTime = TimeValue ( INT64_MAX,0 ); const TimeValue TimeValue::ZeroTime = TimeValue ( 0,0 ); -const TimeValue TimeValue::PosixZeroTime = TimeValue ( -946684800,0 ); -const TimeValue TimeValue::Win32ZeroTime = TimeValue ( -12591158400ULL,0 ); +const TimeValue TimeValue::PosixZeroTime = TimeValue ( PosixZeroTimeSeconds,0 ); +const TimeValue TimeValue::Win32ZeroTime = TimeValue ( Win32ZeroTimeSeconds,0 ); void TimeValue::normalize( void ) { |