summaryrefslogtreecommitdiff
path: root/lib/Target/ARM/README.txt
diff options
context:
space:
mode:
authorJim Grosbach <grosbach@apple.com>2012-07-06 21:52:04 +0000
committerJim Grosbach <grosbach@apple.com>2012-07-06 21:52:04 +0000
commitdb6faeb19d59deab232502da7d529abc4404171a (patch)
treedb9eda7b5efe977ac6cfd931592166ed184c9431 /lib/Target/ARM/README.txt
parent63d10fbc89c02758cd91e3b53749e55c2bd0cf65 (diff)
downloadllvm-db6faeb19d59deab232502da7d529abc4404171a.tar.gz
llvm-db6faeb19d59deab232502da7d529abc4404171a.tar.bz2
llvm-db6faeb19d59deab232502da7d529abc4404171a.tar.xz
ARM: Add test cleanup entry to the README.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@159864 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/ARM/README.txt')
-rw-r--r--lib/Target/ARM/README.txt21
1 files changed, 21 insertions, 0 deletions
diff --git a/lib/Target/ARM/README.txt b/lib/Target/ARM/README.txt
index 3eddda812f..57dc6cb88b 100644
--- a/lib/Target/ARM/README.txt
+++ b/lib/Target/ARM/README.txt
@@ -710,3 +710,24 @@ targets, e.g., PPC, that share this behavior, it would be best to implement
this in a target-independent way: we should probably fold that (when using
"undefined at zero" semantics) to set the "defined at zero" bit and have
the code generator expand out the right code.
+
+
+//===---------------------------------------------------------------------===//
+
+Clean up the test/MC/ARM files to have more robust register choices.
+
+R0 should not be used as a register operand in the assembler tests as it's then
+not possible to distinguish between a correct encoding and a missing operand
+encoding, as zero is the default value for the binary encoder.
+e.g.,
+ add r0, r0 // bad
+ add r3, r5 // good
+
+Register operands should be distinct. That is, when the encoding does not
+require two syntactical operands to refer to the same register, two different
+registers should be used in the test so as to catch errors where the
+operands are swapped in the encoding.
+e.g.,
+ subs.w r1, r1, r1 // bad
+ subs.w r1, r2, r3 // good
+