diff options
| author | Bill Wendling <isanbard@gmail.com> | 2012-08-17 18:33:14 +0000 |
|---|---|---|
| committer | Bill Wendling <isanbard@gmail.com> | 2012-08-17 18:33:14 +0000 |
| commit | 32811bef956e0fae4329e6515420d85f7e510660 (patch) | |
| tree | 13100e97e25505d643790bc4cb43c45fee52a4b8 /lib/Target/Mangler.cpp | |
| parent | d5118c8f78a05ad0b426b6032138d1d934b77c8d (diff) | |
| download | llvm-32811bef956e0fae4329e6515420d85f7e510660.tar.gz llvm-32811bef956e0fae4329e6515420d85f7e510660.tar.bz2 llvm-32811bef956e0fae4329e6515420d85f7e510660.tar.xz | |
Change the `linker_private_weak_def_auto' linkage to `linkonce_odr_auto_hide' to
make it more consistent with its intended semantics.
The `linker_private_weak_def_auto' linkage type was meant to automatically hide
globals which never had their addresses taken. It has nothing to do with the
`linker_private' linkage type, which outputs the symbols with a `l' (ell) prefix
among other things.
The intended semantic is more like the `linkonce_odr' linkage type.
Change the name of the linkage type to `linkonce_odr_auto_hide'. And therefore
changing the semantics so that it produces the correct output for the linker.
Note: The old linkage name `linker_private_weak_def_auto' will still parse but
is not a synonym for `linkonce_odr_auto_hide'. This should be removed in 4.0.
<rdar://problem/11754934>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@162114 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/Mangler.cpp')
| -rw-r--r-- | lib/Target/Mangler.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/Target/Mangler.cpp b/lib/Target/Mangler.cpp index 786a0c5ed1..05f6fa64b9 100644 --- a/lib/Target/Mangler.cpp +++ b/lib/Target/Mangler.cpp @@ -183,8 +183,7 @@ void Mangler::getNameWithPrefix(SmallVectorImpl<char> &OutName, ManglerPrefixTy PrefixTy = Mangler::Default; if (GV->hasPrivateLinkage() || isImplicitlyPrivate) PrefixTy = Mangler::Private; - else if (GV->hasLinkerPrivateLinkage() || GV->hasLinkerPrivateWeakLinkage() || - GV->hasLinkerPrivateWeakDefAutoLinkage()) + else if (GV->hasLinkerPrivateLinkage() || GV->hasLinkerPrivateWeakLinkage()) PrefixTy = Mangler::LinkerPrivate; // If this global has a name, handle it simply. |