diff options
author | Dale Johannesen <dalej@apple.com> | 2009-08-18 00:18:39 +0000 |
---|---|---|
committer | Dale Johannesen <dalej@apple.com> | 2009-08-18 00:18:39 +0000 |
commit | 5cfd4ddece1b73a719830ae84eb74d491f87b9d5 (patch) | |
tree | 17a2abe12b29d5b73327c4bd0b9fd4aba95eab82 /lib/Target/PowerPC/PPCISelDAGToDAG.cpp | |
parent | 4b49cd298a372b58d22ae41cba7a379e9325bfbd (diff) | |
download | llvm-5cfd4ddece1b73a719830ae84eb74d491f87b9d5.tar.gz llvm-5cfd4ddece1b73a719830ae84eb74d491f87b9d5.tar.bz2 llvm-5cfd4ddece1b73a719830ae84eb74d491f87b9d5.tar.xz |
PowerPC inline asm was emitting two output operands
for a single "m" constraint; this is wrong because the
opcode of a load or store would have to change in parallel.
This patch makes it always compute addresses into a register,
which is correct but not as efficient as possible. 7144566.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@79292 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/PowerPC/PPCISelDAGToDAG.cpp')
-rw-r--r-- | lib/Target/PowerPC/PPCISelDAGToDAG.cpp | 28 |
1 files changed, 6 insertions, 22 deletions
diff --git a/lib/Target/PowerPC/PPCISelDAGToDAG.cpp b/lib/Target/PowerPC/PPCISelDAGToDAG.cpp index d9a4daefb1..1a068f0981 100644 --- a/lib/Target/PowerPC/PPCISelDAGToDAG.cpp +++ b/lib/Target/PowerPC/PPCISelDAGToDAG.cpp @@ -143,30 +143,14 @@ namespace { } /// SelectInlineAsmMemoryOperand - Implement addressing mode selection for - /// inline asm expressions. - virtual bool SelectInlineAsmMemoryOperand(const SDValue &Op, + /// inline asm expressions. It is always correct to compute the value into + /// a register. The case of adding a (possibly relocatable) constant to a + /// register can be improved, but it is wrong to substitute Reg+Reg for + /// Reg in an asm, because the load or store opcode would have to change. + virtual bool SelectInlineAsmMemoryOperand(const SDValue &Op, char ConstraintCode, std::vector<SDValue> &OutOps) { - SDValue Op0, Op1; - switch (ConstraintCode) { - default: return true; - case 'm': // memory - if (!SelectAddrIdx(Op, Op, Op0, Op1)) - SelectAddrImm(Op, Op, Op0, Op1); - break; - case 'o': // offsetable - if (!SelectAddrImm(Op, Op, Op0, Op1)) { - Op0 = Op; - Op1 = getSmallIPtrImm(0); - } - break; - case 'v': // not offsetable - SelectAddrIdxOnly(Op, Op, Op0, Op1); - break; - } - - OutOps.push_back(Op0); - OutOps.push_back(Op1); + OutOps.push_back(Op); return false; } |