diff options
| author | Chris Lattner <sabre@nondot.org> | 2010-01-08 17:48:19 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2010-01-08 17:48:19 +0000 |
| commit | 9aa1e246dd15dfc73a2f6f44766ca97ba9573c9d (patch) | |
| tree | 1018ad7d6d9fe65913d31e8be7d715da5d76a2bd /lib | |
| parent | d248ffb7d57cc7aa4216b79741b372026936ea0a (diff) | |
| download | llvm-9aa1e246dd15dfc73a2f6f44766ca97ba9573c9d.tar.gz llvm-9aa1e246dd15dfc73a2f6f44766ca97ba9573c9d.tar.bz2 llvm-9aa1e246dd15dfc73a2f6f44766ca97ba9573c9d.tar.xz | |
tidy up some stuff duncan pointed out.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93007 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/Transforms/InstCombine/InstCombineCompares.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/Transforms/InstCombine/InstCombineCompares.cpp b/lib/Transforms/InstCombine/InstCombineCompares.cpp index abbc89b0a1..e59406c636 100644 --- a/lib/Transforms/InstCombine/InstCombineCompares.cpp +++ b/lib/Transforms/InstCombine/InstCombineCompares.cpp @@ -705,7 +705,7 @@ Instruction *InstCombiner::FoldICmpAddOpCst(ICmpInst &ICI, // so the values can never be equal. Similiarly for all other "or equals" // operators. - // (X+1) <u X --> X >u (MAXUINT-1) --> X != 255 + // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { @@ -713,7 +713,8 @@ Instruction *InstCombiner::FoldICmpAddOpCst(ICmpInst &ICI, if (isNUW) return ReplaceInstUsesWith(ICI, ConstantInt::getFalse(X->getContext())); - Value *R = ConstantExpr::getSub(ConstantInt::get(CI->getType(), -1ULL), CI); + Value *R = + ConstantExpr::getSub(ConstantInt::getAllOnesValue(CI->getType()), CI); return new ICmpInst(ICmpInst::ICMP_UGT, X, R); } |