diff options
| author | Chris Lattner <sabre@nondot.org> | 2008-02-13 07:39:09 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2008-02-13 07:39:09 +0000 |
| commit | 86ca3cacc5a56e862c8258ac9c9ee1e37598ebd8 (patch) | |
| tree | a5dc833f567bdc8e9804499dc941822227d0a006 /test/CodeGen/X86/arg-cast.ll | |
| parent | 9f72d1a73029ed3bfb1f8ced755a1aeeb36fb4f1 (diff) | |
| download | llvm-86ca3cacc5a56e862c8258ac9c9ee1e37598ebd8.tar.gz llvm-86ca3cacc5a56e862c8258ac9c9ee1e37598ebd8.tar.bz2 llvm-86ca3cacc5a56e862c8258ac9c9ee1e37598ebd8.tar.xz | |
In SDISel, for targets that support FORMAL_ARGUMENTS nodes, lower this
node as soon as we create it in SDISel. Previously we would lower it in
legalize. The problem with this is that it only exposes the argument
loads implied by FORMAL_ARGUMENTs after legalize, so that only dag combine 2
can hack on them. This causes us to miss some optimizations because
datatype expansion also happens here.
Exposing the loads early allows us to do optimizations on them. For example
we now compile arg-cast.ll to:
_foo:
movl $2147483647, %eax
andl 8(%esp), %eax
ret
where we previously produced:
_foo:
subl $12, %esp
movsd 16(%esp), %xmm0
movsd %xmm0, (%esp)
movl $2147483647, %eax
andl 4(%esp), %eax
addl $12, %esp
ret
It might also make sense to do this for ISD::CALL nodes, which have implicit
stores on many targets.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@47054 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/CodeGen/X86/arg-cast.ll')
| -rw-r--r-- | test/CodeGen/X86/arg-cast.ll | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/test/CodeGen/X86/arg-cast.ll b/test/CodeGen/X86/arg-cast.ll new file mode 100644 index 0000000000..37afbc6ba6 --- /dev/null +++ b/test/CodeGen/X86/arg-cast.ll @@ -0,0 +1,18 @@ +; This should compile to movl $2147483647, %eax + andl only. +; RUN: llvm-as < %s | llc | grep andl +; RUN: llvm-as < %s | llc | not grep movsd +; RUN: llvm-as < %s | llc | not grep esp +; rdar://5736574 + +target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128" +target triple = "i686-apple-darwin8" + +define i32 @foo(double %x) nounwind { +entry: + %x15 = bitcast double %x to i64 ; <i64> [#uses=1] + %tmp713 = lshr i64 %x15, 32 ; <i64> [#uses=1] + %tmp714 = trunc i64 %tmp713 to i32 ; <i32> [#uses=1] + %tmp8 = and i32 %tmp714, 2147483647 ; <i32> [#uses=1] + ret i32 %tmp8 +} + |