summaryrefslogtreecommitdiff
path: root/tools/llvm-readobj
diff options
context:
space:
mode:
authorSaleem Abdulrasool <compnerd@compnerd.org>2014-05-25 21:37:59 +0000
committerSaleem Abdulrasool <compnerd@compnerd.org>2014-05-25 21:37:59 +0000
commitd29bdc72bbefc938a23b51ac4282548d6e36d317 (patch)
tree46e466c7949f7f7a47c276194af1d7bd643d9a32 /tools/llvm-readobj
parentb6a667f0335027a8ed673d29af11fc6653781c11 (diff)
downloadllvm-d29bdc72bbefc938a23b51ac4282548d6e36d317.tar.gz
llvm-d29bdc72bbefc938a23b51ac4282548d6e36d317.tar.bz2
llvm-d29bdc72bbefc938a23b51ac4282548d6e36d317.tar.xz
tools: avoid use of std::function
Remove the use of the std::function and replace the capturing lambda with a non-capturing one, opting to pass the user data down to the context. This is needed as std::function is not yet available on all hosted platforms (it requires RTTI, which breaks on Windows). Thanks to Nico Rieck for pointing this out! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209607 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools/llvm-readobj')
-rw-r--r--tools/llvm-readobj/COFFDumper.cpp9
-rw-r--r--tools/llvm-readobj/Win64EHDumper.cpp5
-rw-r--r--tools/llvm-readobj/Win64EHDumper.h12
3 files changed, 14 insertions, 12 deletions
diff --git a/tools/llvm-readobj/COFFDumper.cpp b/tools/llvm-readobj/COFFDumper.cpp
index 7b9595f84c..91f2a57dcc 100644
--- a/tools/llvm-readobj/COFFDumper.cpp
+++ b/tools/llvm-readobj/COFFDumper.cpp
@@ -849,11 +849,12 @@ void COFFDumper::printUnwindInfo() {
case COFF::IMAGE_FILE_MACHINE_AMD64: {
Win64EH::Dumper Dumper(W);
Win64EH::Dumper::SymbolResolver Resolver =
- [this](const object::coff_section *Section, uint64_t Offset,
- SymbolRef &Symbol) -> error_code {
- return this->resolveSymbol(Section, Offset, Symbol);
+ [](const object::coff_section *Section, uint64_t Offset,
+ SymbolRef &Symbol, void *user_data) -> error_code {
+ COFFDumper *Dumper = reinterpret_cast<COFFDumper*>(user_data);
+ return Dumper->resolveSymbol(Section, Offset, Symbol);
};
- Win64EH::Dumper::Context Ctx(*Obj, Resolver);
+ Win64EH::Dumper::Context Ctx(*Obj, Resolver, this);
Dumper.printData(Ctx);
break;
}
diff --git a/tools/llvm-readobj/Win64EHDumper.cpp b/tools/llvm-readobj/Win64EHDumper.cpp
index 449df001cc..c64d362469 100644
--- a/tools/llvm-readobj/Win64EHDumper.cpp
+++ b/tools/llvm-readobj/Win64EHDumper.cpp
@@ -120,7 +120,8 @@ static std::string formatSymbol(const Dumper::Context &Ctx,
StringRef Name;
SymbolRef Symbol;
- if (Ctx.ResolveSymbol(Section, Offset, Symbol) || Symbol.getName(Name)) {
+ if (Ctx.ResolveSymbol(Section, Offset, Symbol, Ctx.UserData) ||
+ Symbol.getName(Name)) {
OS << format(" (0x%" PRIX64 ")", Offset);
return OS.str();
}
@@ -139,7 +140,7 @@ static error_code resolveRelocation(const Dumper::Context &Ctx,
const coff_section *&ResolvedSection,
uint64_t &ResolvedAddress) {
SymbolRef Symbol;
- if (error_code EC = Ctx.ResolveSymbol(Section, Offset, Symbol))
+ if (error_code EC = Ctx.ResolveSymbol(Section, Offset, Symbol, Ctx.UserData))
return EC;
if (error_code EC = Symbol.getAddress(ResolvedAddress))
diff --git a/tools/llvm-readobj/Win64EHDumper.h b/tools/llvm-readobj/Win64EHDumper.h
index d0c129c68b..2eac81048b 100644
--- a/tools/llvm-readobj/Win64EHDumper.h
+++ b/tools/llvm-readobj/Win64EHDumper.h
@@ -13,8 +13,6 @@
#include "StreamWriter.h"
#include "llvm/Support/Win64EH.h"
-#include <functional>
-
namespace llvm {
namespace object {
class COFFObjectFile;
@@ -28,15 +26,17 @@ class Dumper {
raw_ostream &OS;
public:
- typedef std::function<error_code(const object::coff_section *, uint64_t,
- object::SymbolRef &)> SymbolResolver;
+ typedef error_code (*SymbolResolver)(const object::coff_section *, uint64_t,
+ object::SymbolRef &, void *);
struct Context {
const object::COFFObjectFile &COFF;
SymbolResolver ResolveSymbol;
+ void *UserData;
- Context(const object::COFFObjectFile &COFF, SymbolResolver Resolver)
- : COFF(COFF), ResolveSymbol(Resolver) {}
+ Context(const object::COFFObjectFile &COFF, SymbolResolver Resolver,
+ void *UserData)
+ : COFF(COFF), ResolveSymbol(Resolver), UserData(UserData) {}
};
private: