summaryrefslogtreecommitdiff
path: root/unittests
diff options
context:
space:
mode:
authorNikola Smiljanic <popizdeh@gmail.com>2014-06-19 00:26:49 +0000
committerNikola Smiljanic <popizdeh@gmail.com>2014-06-19 00:26:49 +0000
commit1260b844fd71720566eabd4cc5738f2abe747871 (patch)
treeb32fc7b9c50633711f0dca708780174daa5c9ccb /unittests
parent887a5c7f5da73ada835985d1f9552ff1716517a7 (diff)
downloadllvm-1260b844fd71720566eabd4cc5738f2abe747871.tar.gz
llvm-1260b844fd71720566eabd4cc5738f2abe747871.tar.bz2
llvm-1260b844fd71720566eabd4cc5738f2abe747871.tar.xz
PR10140 - StringPool's PooledStringPtr has non-const operator== causing bad OR-result.
Mark conversion operator explicit and const qualify comparison operators. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@211244 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests')
-rw-r--r--unittests/Support/CMakeLists.txt1
-rw-r--r--unittests/Support/StringPool.cpp31
2 files changed, 32 insertions, 0 deletions
diff --git a/unittests/Support/CMakeLists.txt b/unittests/Support/CMakeLists.txt
index 0ea9310333..c50acdfb8e 100644
--- a/unittests/Support/CMakeLists.txt
+++ b/unittests/Support/CMakeLists.txt
@@ -30,6 +30,7 @@ add_llvm_unittest(SupportTests
ProgramTest.cpp
RegexTest.cpp
SourceMgrTest.cpp
+ StringPool.cpp
SwapByteOrderTest.cpp
ThreadLocalTest.cpp
TimeValueTest.cpp
diff --git a/unittests/Support/StringPool.cpp b/unittests/Support/StringPool.cpp
new file mode 100644
index 0000000000..7b7805f917
--- /dev/null
+++ b/unittests/Support/StringPool.cpp
@@ -0,0 +1,31 @@
+//===- llvm/unittest/Support/ThreadLocalTest.cpp - Therad Local tests ---===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/Support/StringPool.h"
+#include "gtest/gtest.h"
+
+using namespace llvm;
+
+namespace {
+
+TEST(PooledStringPtrTest, OperatorEquals) {
+ StringPool pool;
+ const PooledStringPtr a = pool.intern("a");
+ const PooledStringPtr b = pool.intern("b");
+ EXPECT_FALSE(a == b);
+}
+
+TEST(PooledStringPtrTest, OperatorNotEquals) {
+ StringPool pool;
+ const PooledStringPtr a = pool.intern("a");
+ const PooledStringPtr b = pool.intern("b");
+ EXPECT_TRUE(a != b);
+}
+
+}