From 44402c0701c9855d840812bc0586d23b46228e21 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 6 Oct 2010 05:20:57 +0000 Subject: refactor things a bit, now the REX_W and OpSize prefix bytes are inferred from the type info. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@115745 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/X86/X86InstrArithmetic.td | 68 ++++++++++++++++++++++++------------ 1 file changed, 46 insertions(+), 22 deletions(-) diff --git a/lib/Target/X86/X86InstrArithmetic.td b/lib/Target/X86/X86InstrArithmetic.td index d22b888df9..fb9474c00f 100644 --- a/lib/Target/X86/X86InstrArithmetic.td +++ b/lib/Target/X86/X86InstrArithmetic.td @@ -495,11 +495,13 @@ let CodeSize = 2 in { } // CodeSize = 2 } // Defs = [EFLAGS] + /// X86TypeInfo - This is a bunch of information that describes relevant X86 /// information about value types. For example, it can tell you what the /// register class and preferred load to use. class X86TypeInfo { + PatFrag loadnode, X86MemOperand memoperand, + bit hasOpSizePrefix, bit hasREX_WPrefix> { /// VT - This is the value type itself. ValueType VT = vt; @@ -518,33 +520,55 @@ class X86TypeInfo i8mem, i16 -> i16mem, i32 -> i32mem, i64 -> i64mem. X86MemOperand MemOperand = memoperand; + + /// HasOpSizePrefix - This bit is set to true if the instruction should have + /// the 0x66 operand size prefix. This is set for i16 types. + bit HasOpSizePrefix = hasOpSizePrefix; + + /// HasREX_WPrefix - This bit is set to true if the instruction should have + /// the 0x40 REX prefix. This is set for i64 types. + bit HasREX_WPrefix = hasREX_WPrefix; } -def Xi8 : X86TypeInfo; -def Xi16 : X86TypeInfo; -def Xi32 : X86TypeInfo; -def Xi64 : X86TypeInfo; +def Xi8 : X86TypeInfo; +def Xi16 : X86TypeInfo; +def Xi32 : X86TypeInfo; +def Xi64 : X86TypeInfo; + +/// ITy - This instruction base class takes the type info for the instruction. +/// Using this, it: +/// 1. Concatenates together the instruction mnemonic with the appropriate +/// suffix letter, a tab, and the arguments. +/// 2. Infers whether the instruction should have a 0x66 prefix byte. +/// 3. Infers whether the instruction should have a 0x40 REX_W prefix. +class ITy opcode, Format f, X86TypeInfo typeinfo, dag outs, dag ins, + string mnemonic, string args, list pattern> + : I { + + // Infer instruction prefixes from type info. + let hasOpSizePrefix = typeinfo.HasOpSizePrefix; + let hasREX_WPrefix = typeinfo.HasREX_WPrefix; +} class BinOpRR opcode, string mnemonic, X86TypeInfo typeinfo, SDNode opnode, Format format> - : I; + : ITy; class BinOpRM opcode, string mnemonic, X86TypeInfo typeinfo, SDNode opnode> - : I; @@ -554,9 +578,9 @@ let Constraints = "$src1 = $dst" in { let isCommutable = 1 in { // X = AND Y, Z --> X = AND Z, Y def AND8rr : BinOpRR<0x20, "and", Xi8 , X86and_flag, MRMDestReg>; -def AND16rr : BinOpRR<0x21, "and", Xi16, X86and_flag, MRMDestReg>, OpSize; +def AND16rr : BinOpRR<0x21, "and", Xi16, X86and_flag, MRMDestReg>; def AND32rr : BinOpRR<0x21, "and", Xi32, X86and_flag, MRMDestReg>; -def AND64rr : BinOpRR<0x21, "and", Xi64, X86and_flag, MRMDestReg>, REX_W; +def AND64rr : BinOpRR<0x21, "and", Xi64, X86and_flag, MRMDestReg>; } // isCommutable @@ -577,9 +601,9 @@ def AND64rr_REV : RI<0x23, MRMSrcReg, (outs GR64:$dst), } def AND8rm : BinOpRM<0x22, "and", Xi8 , X86and_flag>; -def AND16rm : BinOpRM<0x23, "and", Xi16, X86and_flag>, OpSize; +def AND16rm : BinOpRM<0x23, "and", Xi16, X86and_flag>; def AND32rm : BinOpRM<0x23, "and", Xi32, X86and_flag>; -def AND64rm : BinOpRM<0x23, "and", Xi64, X86and_flag>, REX_W; +def AND64rm : BinOpRM<0x23, "and", Xi64, X86and_flag>; def AND8ri : Ii8<0x80, MRM4r, (outs GR8 :$dst), (ins GR8 :$src1, i8imm :$src2), -- cgit v1.2.3