From c8cfaa1625a72aa3660a268dae753748cfed67d0 Mon Sep 17 00:00:00 2001 From: Manman Ren Date: Tue, 16 Jul 2013 23:21:16 +0000 Subject: Add getModuleFlag(StringRef Key) to query a module flag given Key. No functionality change. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186470 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/IR/Module.h | 4 ++++ lib/CodeGen/AsmPrinter/DwarfDebug.cpp | 15 ++++----------- lib/IR/Module.cpp | 13 +++++++++++++ 3 files changed, 21 insertions(+), 11 deletions(-) diff --git a/include/llvm/IR/Module.h b/include/llvm/IR/Module.h index d414405818..2514be4faa 100644 --- a/include/llvm/IR/Module.h +++ b/include/llvm/IR/Module.h @@ -405,6 +405,10 @@ public: /// getModuleFlagsMetadata - Returns the module flags in the provided vector. void getModuleFlagsMetadata(SmallVectorImpl &Flags) const; + /// Return the corresponding value if Key appears in module flags, otherwise + /// return null. + Value *getModuleFlag(StringRef Key) const; + /// getModuleFlagsMetadata - Returns the NamedMDNode in the module that /// represents module-level flags. This method returns null if there are no /// module-level flags. diff --git a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp index a35cfa2ec9..254ecd256d 100644 --- a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp +++ b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp @@ -164,17 +164,10 @@ DIType DbgVariable::getType() const { /// Return Dwarf Version by checking module flags. static unsigned getDwarfVersionFromModule(const Module *M) { - SmallVector ModuleFlags; - M->getModuleFlagsMetadata(ModuleFlags); - for (unsigned I = 0, E = ModuleFlags.size(); I < E; ++I) { - const Module::ModuleFlagEntry &MFE = ModuleFlags[I]; - StringRef Key = MFE.Key->getString(); - Value *Val = MFE.Val; - - if (Key == "Dwarf Version") - return cast(Val)->getZExtValue(); - } - return dwarf::DWARF_VERSION; + Value *Val = M->getModuleFlag("Dwarf Version"); + if (!Val) + return dwarf::DWARF_VERSION; + return cast(Val)->getZExtValue(); } DwarfDebug::DwarfDebug(AsmPrinter *A, Module *M) diff --git a/lib/IR/Module.cpp b/lib/IR/Module.cpp index 3f505aa3e0..3d3dc737a1 100644 --- a/lib/IR/Module.cpp +++ b/lib/IR/Module.cpp @@ -325,6 +325,19 @@ getModuleFlagsMetadata(SmallVectorImpl &Flags) const { } } +/// Return the corresponding value if Key appears in module flags, otherwise +/// return null. +Value *Module::getModuleFlag(StringRef Key) const { + SmallVector ModuleFlags; + getModuleFlagsMetadata(ModuleFlags); + for (unsigned I = 0, E = ModuleFlags.size(); I < E; ++I) { + const ModuleFlagEntry &MFE = ModuleFlags[I]; + if (Key == MFE.Key->getString()) + return MFE.Val; + } + return 0; +} + /// getModuleFlagsMetadata - Returns the NamedMDNode in the module that /// represents module-level flags. This method returns null if there are no /// module-level flags. -- cgit v1.2.3