From d68ef1a8d725ef8890dbd8ef7a7f202b735e02b1 Mon Sep 17 00:00:00 2001 From: Alexander Potapenko Date: Thu, 20 Mar 2014 10:48:34 +0000 Subject: [ASan] Do not instrument globals from the llvm.metadata section. Fixes https://code.google.com/p/address-sanitizer/issues/detail?id=279. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204331 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Instrumentation/AddressSanitizer.cpp | 2 ++ .../AddressSanitizer/do-not-instrument-llvm-metadata.ll | 12 ++++++++++++ 2 files changed, 14 insertions(+) create mode 100644 test/Instrumentation/AddressSanitizer/do-not-instrument-llvm-metadata.ll diff --git a/lib/Transforms/Instrumentation/AddressSanitizer.cpp b/lib/Transforms/Instrumentation/AddressSanitizer.cpp index 5c35cc8faf..a19e1f7063 100644 --- a/lib/Transforms/Instrumentation/AddressSanitizer.cpp +++ b/lib/Transforms/Instrumentation/AddressSanitizer.cpp @@ -927,6 +927,8 @@ bool AddressSanitizerModule::ShouldInstrumentGlobal(GlobalVariable *G) { DEBUG(dbgs() << "Ignoring a cstring literal: " << *G << "\n"); return false; } + // Globals from llvm.metadata aren't emitted, do not instrument them. + if (Section == "llvm.metadata") return false; } return true; diff --git a/test/Instrumentation/AddressSanitizer/do-not-instrument-llvm-metadata.ll b/test/Instrumentation/AddressSanitizer/do-not-instrument-llvm-metadata.ll new file mode 100644 index 0000000000..fbfc096577 --- /dev/null +++ b/test/Instrumentation/AddressSanitizer/do-not-instrument-llvm-metadata.ll @@ -0,0 +1,12 @@ +; This test checks that we are not instrumenting globals in llvm.metadata. +; RUN: opt < %s -asan -asan-module -S | FileCheck %s + +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-linux-gnu" + +@.str_noinst = private unnamed_addr constant [4 x i8] c"aaa\00", section "llvm.metadata" +@.str_inst = private unnamed_addr constant [4 x i8] c"aaa\00", + +; CHECK-NOT: {{asan_gen.*str_noinst}} +; CHECK: {{asan_gen.*str_inst}} +; CHECK: @asan.module_ctor -- cgit v1.2.3