From e032590f58e400ba25e416da5bee10a85ad6d114 Mon Sep 17 00:00:00 2001 From: Nick Lewycky Date: Sat, 4 Apr 2009 09:39:23 +0000 Subject: CloneModule stores the BasicBlock mapping in ValueMap. There's no need to recompute it. This fixes a O(n^2) in number of blocks when reducing a crash. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@68422 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/bugpoint/CrashDebugger.cpp | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/tools/bugpoint/CrashDebugger.cpp b/tools/bugpoint/CrashDebugger.cpp index ba12621ad9..4225a40c74 100644 --- a/tools/bugpoint/CrashDebugger.cpp +++ b/tools/bugpoint/CrashDebugger.cpp @@ -21,6 +21,7 @@ #include "llvm/Pass.h" #include "llvm/PassManager.h" #include "llvm/ValueSymbolTable.h" +#include "llvm/ADT/SmallPtrSet.h" #include "llvm/Analysis/Verifier.h" #include "llvm/Support/CFG.h" #include "llvm/Transforms/Scalar.h" @@ -267,21 +268,9 @@ bool ReduceCrashingBlocks::TestBlocks(std::vector &BBs) { Module *M = CloneModule(BD.getProgram(), ValueMap); // Convert list to set for fast lookup... - std::set Blocks; - for (unsigned i = 0, e = BBs.size(); i != e; ++i) { - // Convert the basic block from the original module to the new module... - const Function *F = BBs[i]->getParent(); - Function *CMF = cast(ValueMap[F]); - assert(CMF && "Function not in module?!"); - assert(CMF->getFunctionType() == F->getFunctionType() && "wrong type?"); - assert(CMF->getName() == F->getName() && "wrong name?"); - - // Get the mapped basic block... - Function::iterator CBI = CMF->begin(); - std::advance(CBI, std::distance(F->begin(), - Function::const_iterator(BBs[i]))); - Blocks.insert(CBI); - } + SmallPtrSet Blocks; + for (unsigned i = 0, e = BBs.size(); i != e; ++i) + Blocks.insert(cast(ValueMap[BBs[i]])); std::cout << "Checking for crash with only these blocks:"; unsigned NumPrint = Blocks.size(); @@ -320,8 +309,8 @@ bool ReduceCrashingBlocks::TestBlocks(std::vector &BBs) { // have to take. std::vector > BlockInfo; - for (std::set::iterator I = Blocks.begin(), E = Blocks.end(); - I != E; ++I) + for (SmallPtrSet::iterator I = Blocks.begin(), + E = Blocks.end(); I != E; ++I) BlockInfo.push_back(std::make_pair((*I)->getParent(), (*I)->getName())); // Now run the CFG simplify pass on the function... -- cgit v1.2.3