From e09411dd68534824b0a79749da44589983061d07 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Sat, 8 Feb 2014 14:53:28 +0000 Subject: Pass the Mangler by reference. It is never null and it is not used in casts, so there is no reason to use a pointer. This matches how we pass TM. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@201025 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../llvm/CodeGen/TargetLoweringObjectFileImpl.h | 26 +++++++++++----------- include/llvm/Target/TargetLoweringObjectFile.h | 25 ++++++++++----------- 2 files changed, 25 insertions(+), 26 deletions(-) (limited to 'include') diff --git a/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h b/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h index 9660a065a0..c43a0a6c70 100644 --- a/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h +++ b/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h @@ -46,25 +46,25 @@ public: const MCSection *getSectionForConstant(SectionKind Kind) const LLVM_OVERRIDE; const MCSection *getExplicitSectionGlobal(const GlobalValue *GV, - SectionKind Kind, Mangler *Mang, + SectionKind Kind, Mangler &Mang, const TargetMachine &TM) const LLVM_OVERRIDE; const MCSection *SelectSectionForGlobal(const GlobalValue *GV, - SectionKind Kind, Mangler *Mang, + SectionKind Kind, Mangler &Mang, const TargetMachine &TM) const LLVM_OVERRIDE; /// Return an MCExpr to use for a reference to the specified type info global /// variable from exception handling information. - const MCExpr *getTTypeGlobalReference(const GlobalValue *GV, Mangler *Mang, + const MCExpr *getTTypeGlobalReference(const GlobalValue *GV, Mangler &Mang, MachineModuleInfo *MMI, unsigned Encoding, MCStreamer &Streamer) const LLVM_OVERRIDE; // The symbol that gets passed to .cfi_personality. - MCSymbol *getCFIPersonalitySymbol(const GlobalValue *GV, Mangler *Mang, + MCSymbol *getCFIPersonalitySymbol(const GlobalValue *GV, Mangler &Mang, MachineModuleInfo *MMI) const LLVM_OVERRIDE; void InitializeELF(bool UseInitArray_); @@ -87,16 +87,16 @@ public: /// Emit the module flags that specify the garbage collection information. void emitModuleFlags(MCStreamer &Streamer, ArrayRef ModuleFlags, - Mangler *Mang, const TargetMachine &TM) const + Mangler &Mang, const TargetMachine &TM) const LLVM_OVERRIDE; const MCSection *SelectSectionForGlobal(const GlobalValue *GV, - SectionKind Kind, Mangler *Mang, + SectionKind Kind, Mangler &Mang, const TargetMachine &TM) const LLVM_OVERRIDE; const MCSection *getExplicitSectionGlobal(const GlobalValue *GV, - SectionKind Kind, Mangler *Mang, + SectionKind Kind, Mangler &Mang, const TargetMachine &TM) const LLVM_OVERRIDE; @@ -105,18 +105,18 @@ public: /// This hook allows targets to selectively decide not to emit the /// UsedDirective for some symbols in llvm.used. /// FIXME: REMOVE this (rdar://7071300) - bool shouldEmitUsedDirectiveFor(const GlobalValue *GV, Mangler *Mang) const + bool shouldEmitUsedDirectiveFor(const GlobalValue *GV, Mangler &Mang) const LLVM_OVERRIDE; /// The mach-o version of this method defaults to returning a stub reference. - const MCExpr *getTTypeGlobalReference(const GlobalValue *GV, Mangler *Mang, + const MCExpr *getTTypeGlobalReference(const GlobalValue *GV, Mangler &Mang, MachineModuleInfo *MMI, unsigned Encoding, MCStreamer &Streamer) const LLVM_OVERRIDE; // The symbol that gets passed to .cfi_personality. - MCSymbol *getCFIPersonalitySymbol(const GlobalValue *GV, Mangler *Mang, + MCSymbol *getCFIPersonalitySymbol(const GlobalValue *GV, Mangler &Mang, MachineModuleInfo *MMI) const LLVM_OVERRIDE; }; @@ -127,12 +127,12 @@ public: virtual ~TargetLoweringObjectFileCOFF() {} const MCSection *getExplicitSectionGlobal(const GlobalValue *GV, - SectionKind Kind, Mangler *Mang, + SectionKind Kind, Mangler &Mang, const TargetMachine &TM) const LLVM_OVERRIDE; const MCSection *SelectSectionForGlobal(const GlobalValue *GV, - SectionKind Kind, Mangler *Mang, + SectionKind Kind, Mangler &Mang, const TargetMachine &TM) const LLVM_OVERRIDE; @@ -144,7 +144,7 @@ public: /// emission is implemented for COFF. void emitModuleFlags(MCStreamer &Streamer, ArrayRef ModuleFlags, - Mangler *Mang, const TargetMachine &TM) const + Mangler &Mang, const TargetMachine &TM) const LLVM_OVERRIDE; }; diff --git a/include/llvm/Target/TargetLoweringObjectFile.h b/include/llvm/Target/TargetLoweringObjectFile.h index 59bb8b436c..c4a3f1cd28 100644 --- a/include/llvm/Target/TargetLoweringObjectFile.h +++ b/include/llvm/Target/TargetLoweringObjectFile.h @@ -64,16 +64,15 @@ public: } /// Emit the module flags that the platform cares about. - virtual void emitModuleFlags(MCStreamer &, - ArrayRef, - Mangler *, const TargetMachine &) const { - } + virtual void emitModuleFlags(MCStreamer &Streamer, + ArrayRef Flags, + Mangler &Mang, const TargetMachine &TM) const {} /// This hook allows targets to selectively decide not to emit the /// UsedDirective for some symbols in llvm.used. /// FIXME: REMOVE this (rdar://7071300) virtual bool shouldEmitUsedDirectiveFor(const GlobalValue *GV, - Mangler *) const { + Mangler &Mang) const { return GV != 0; } @@ -90,14 +89,14 @@ public: /// variable or function definition. This should not be passed external (or /// available externally) globals. const MCSection *SectionForGlobal(const GlobalValue *GV, - SectionKind Kind, Mangler *Mang, + SectionKind Kind, Mangler &Mang, const TargetMachine &TM) const; /// This method computes the appropriate section to emit the specified global /// variable or function definition. This should not be passed external (or /// available externally) globals. const MCSection *SectionForGlobal(const GlobalValue *GV, - Mangler *Mang, + Mangler &Mang, const TargetMachine &TM) const { return SectionForGlobal(GV, getKindForGlobal(GV, TM), Mang, TM); } @@ -107,11 +106,11 @@ public: /// assume that GV->hasSection() is true. virtual const MCSection * getExplicitSectionGlobal(const GlobalValue *GV, SectionKind Kind, - Mangler *Mang, const TargetMachine &TM) const = 0; + Mangler &Mang, const TargetMachine &TM) const = 0; /// Allow the target to completely override section assignment of a global. virtual const MCSection * - getSpecialCasedSectionGlobals(const GlobalValue *GV, Mangler *Mang, + getSpecialCasedSectionGlobals(const GlobalValue *GV, Mangler &Mang, SectionKind Kind) const { return 0; } @@ -119,7 +118,7 @@ public: /// Return an MCExpr to use for a reference to the specified global variable /// from exception handling information. virtual const MCExpr * - getTTypeGlobalReference(const GlobalValue *GV, Mangler *Mang, + getTTypeGlobalReference(const GlobalValue *GV, Mangler &Mang, MachineModuleInfo *MMI, unsigned Encoding, MCStreamer &Streamer) const; @@ -134,7 +133,7 @@ public: // The symbol that gets passed to .cfi_personality. virtual MCSymbol * - getCFIPersonalitySymbol(const GlobalValue *GV, Mangler *Mang, + getCFIPersonalitySymbol(const GlobalValue *GV, Mangler &Mang, MachineModuleInfo *MMI) const; const MCExpr * @@ -157,14 +156,14 @@ public: virtual const MCExpr *getDebugThreadLocalSymbol(const MCSymbol *Sym) const; virtual const MCExpr * - getExecutableRelativeSymbol(const ConstantExpr *CE, Mangler *Mang) const { + getExecutableRelativeSymbol(const ConstantExpr *CE, Mangler &Mang) const { return 0; } protected: virtual const MCSection * SelectSectionForGlobal(const GlobalValue *GV, SectionKind Kind, - Mangler *Mang, const TargetMachine &TM) const; + Mangler &Mang, const TargetMachine &TM) const; }; } // end namespace llvm -- cgit v1.2.3