From 47290de5dbab6a784afbbea16dd3dc895e262ccb Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Mon, 12 May 2014 23:53:03 +0000 Subject: Revert "DebugInfo: Include lexical scopes in inlined subroutines." This reverts commit r208506. Some inlined subroutine scopes appear to be missing with this change. Reverting while I investigate. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208642 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/LexicalScopes.cpp | 40 ++++++++++++---------------------------- 1 file changed, 12 insertions(+), 28 deletions(-) (limited to 'lib/CodeGen/LexicalScopes.cpp') diff --git a/lib/CodeGen/LexicalScopes.cpp b/lib/CodeGen/LexicalScopes.cpp index 8bf69ff630..46f864ca55 100644 --- a/lib/CodeGen/LexicalScopes.cpp +++ b/lib/CodeGen/LexicalScopes.cpp @@ -104,14 +104,6 @@ void LexicalScopes::extractLexicalScopes( } } -LexicalScope *LexicalScopes::findInlinedScope(DebugLoc DL) { - MDNode *Scope = nullptr; - MDNode *IA = nullptr; - DL.getScopeAndInlinedAt(Scope, IA, MF->getFunction()->getContext()); - auto I = InlinedLexicalScopeMap.find(std::make_pair(Scope, IA)); - return I != InlinedLexicalScopeMap.end() ? &I->second : nullptr; -} - /// findLexicalScope - Find lexical scope, either regular or inlined, for the /// given DebugLoc. Return NULL if not found. LexicalScope *LexicalScopes::findLexicalScope(DebugLoc DL) { @@ -127,10 +119,8 @@ LexicalScope *LexicalScopes::findLexicalScope(DebugLoc DL) { if (D.isLexicalBlockFile()) Scope = DILexicalBlockFile(Scope).getScope(); - if (IA) { - auto I = InlinedLexicalScopeMap.find(std::make_pair(Scope, IA)); - return I != InlinedLexicalScopeMap.end() ? &I->second : nullptr; - } + if (IA) + return InlinedLexicalScopeMap.lookup(DebugLoc::getFromDILocation(IA)); return findLexicalScope(Scope); } @@ -180,27 +170,21 @@ LexicalScope *LexicalScopes::getOrCreateRegularScope(MDNode *Scope) { } /// getOrCreateInlinedScope - Find or create an inlined lexical scope. -LexicalScope *LexicalScopes::getOrCreateInlinedScope(MDNode *ScopeNode, +LexicalScope *LexicalScopes::getOrCreateInlinedScope(MDNode *Scope, MDNode *InlinedAt) { - std::pair P(ScopeNode, InlinedAt); - auto I = InlinedLexicalScopeMap.find(P); - if (I != InlinedLexicalScopeMap.end()) + auto I = LexicalScopeMap.find(InlinedAt); + if (I != LexicalScopeMap.end()) return &I->second; - LexicalScope *Parent; - DILexicalBlock Scope(ScopeNode); - if (Scope.isLexicalBlock()) { - DILexicalBlock PB(Scope.getContext()); - Parent = getOrCreateInlinedScope(PB, InlinedAt); - } else - Parent = getOrCreateLexicalScope(DebugLoc::getFromDILocation(InlinedAt)); - + DebugLoc InlinedLoc = DebugLoc::getFromDILocation(InlinedAt); // FIXME: Use forward_as_tuple instead of make_tuple, once MSVC2012 // compatibility is no longer required. - I = InlinedLexicalScopeMap.emplace(std::piecewise_construct, - std::make_tuple(P), - std::make_tuple(Parent, Scope, InlinedAt, - false)).first; + I = LexicalScopeMap.emplace( + std::piecewise_construct, std::make_tuple(InlinedAt), + std::make_tuple(getOrCreateLexicalScope(InlinedLoc), + DIDescriptor(Scope), InlinedAt, + false)).first; + InlinedLexicalScopeMap[InlinedLoc] = &I->second; return &I->second; } -- cgit v1.2.3