From ac69459e0fe3df04788f5adcb94b1bec8b8cf8ad Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Mon, 24 Feb 2014 18:20:12 +0000 Subject: Replace the F_Binary flag with a F_Text one. After this I will set the default back to F_None. The advantage is that before this patch forgetting to set F_Binary would corrupt a file on windows. Forgetting to set F_Text produces one that cannot be read in notepad, which is a better failure mode :-) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202052 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/Windows/Path.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/Support/Windows') diff --git a/lib/Support/Windows/Path.inc b/lib/Support/Windows/Path.inc index a72d0bf0b1..98b2767c01 100644 --- a/lib/Support/Windows/Path.inc +++ b/lib/Support/Windows/Path.inc @@ -876,7 +876,7 @@ error_code openFileForWrite(const Twine &Name, int &ResultFD, if (Flags & F_Append) OpenFlags |= _O_APPEND; - if (!(Flags & F_Binary)) + if (Flags & F_Text) OpenFlags |= _O_TEXT; int FD = ::_open_osfhandle(intptr_t(H), OpenFlags); -- cgit v1.2.3