From a032dbd62f46a40b2cf759ce0dd0ebd41ef0614c Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Fri, 16 Nov 2012 02:39:34 +0000 Subject: [mips] Fix delay slot filler so that instructions with register operand $1 are allowed in branch delay slot. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@168131 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/Mips/MipsDelaySlotFiller.cpp | 51 ++++++++++++++++++++++----------- 1 file changed, 34 insertions(+), 17 deletions(-) (limited to 'lib/Target') diff --git a/lib/Target/Mips/MipsDelaySlotFiller.cpp b/lib/Target/Mips/MipsDelaySlotFiller.cpp index e3c8ed75cf..17a19fb2ab 100644 --- a/lib/Target/Mips/MipsDelaySlotFiller.cpp +++ b/lib/Target/Mips/MipsDelaySlotFiller.cpp @@ -231,31 +231,48 @@ bool Filler::delayHasHazard(InstrIter candidate, return false; } +// Helper function for getting a MachineOperand's register number and adding it +// to RegDefs or RegUses. +static void insertDefUse(const MachineOperand &MO, + SmallSet &RegDefs, + SmallSet &RegUses, + unsigned ExcludedReg = 0) { + unsigned Reg; + + if (!MO.isReg() || !(Reg = MO.getReg()) || (Reg == ExcludedReg)) + return; + + if (MO.isDef()) + RegDefs.insert(Reg); + else if (MO.isUse()) + RegUses.insert(Reg); +} + // Insert Defs and Uses of MI into the sets RegDefs and RegUses. void Filler::insertDefsUses(InstrIter MI, SmallSet &RegDefs, SmallSet &RegUses) { - // If MI is a call or return, just examine the explicit non-variadic operands. - MCInstrDesc MCID = MI->getDesc(); - unsigned e = MI->isCall() || MI->isReturn() ? MCID.getNumOperands() : - MI->getNumOperands(); + unsigned I, E = MI->getDesc().getNumOperands(); - // Add RA to RegDefs to prevent users of RA from going into delay slot. - if (MI->isCall()) - RegDefs.insert(Mips::RA); + for (I = 0; I != E; ++I) + insertDefUse(MI->getOperand(I), RegDefs, RegUses); - for (unsigned i = 0; i != e; ++i) { - const MachineOperand &MO = MI->getOperand(i); - unsigned Reg; + // If MI is a call, add RA to RegDefs to prevent users of RA from going into + // delay slot. + if (MI->isCall()) { + RegDefs.insert(Mips::RA); + return; + } - if (!MO.isReg() || !(Reg = MO.getReg())) - continue; + // Return if MI is a return. + if (MI->isReturn()) + return; - if (MO.isDef()) - RegDefs.insert(Reg); - else if (MO.isUse()) - RegUses.insert(Reg); - } + // Examine the implicit operands. Exclude register AT which is in the list of + // clobbered registers of branch instructions. + E = MI->getNumOperands(); + for (; I != E; ++I) + insertDefUse(MI->getOperand(I), RegDefs, RegUses, Mips::AT); } //returns true if the Reg or its alias is in the RegSet. -- cgit v1.2.3