From e611ea7ee5dcdf41ad513afb1e943a7393e42d96 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Fri, 3 Jan 2014 04:49:04 +0000 Subject: Revert "Debug Info: Type Units: Simplify type hashing using IR-provided unique names." Reverting due to bot failure I won't have time to investigate until tomorrow. This reverts commit r198397. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198398 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/DebugInfo/X86/c-type-units.ll | 5 ++- test/DebugInfo/X86/generate-odr-hash.ll | 57 +++++++++++++++++---------------- 2 files changed, 31 insertions(+), 31 deletions(-) (limited to 'test/DebugInfo') diff --git a/test/DebugInfo/X86/c-type-units.ll b/test/DebugInfo/X86/c-type-units.ll index 386bc8c239..f931d51456 100644 --- a/test/DebugInfo/X86/c-type-units.ll +++ b/test/DebugInfo/X86/c-type-units.ll @@ -5,9 +5,8 @@ ; struct foo { ; } f; -; no known LLVM frontends produce appropriate unique identifiers for C types, -; so we don't produce type units for them -; CHECK-NOT: DW_TAG_type_unit +; CHECK: DW_TAG_type_unit +; CHECK-NEXT: DW_AT_language [DW_FORM_data2] (0x000c) %struct.foo = type {} diff --git a/test/DebugInfo/X86/generate-odr-hash.ll b/test/DebugInfo/X86/generate-odr-hash.ll index 57b6b06d7f..28c4295826 100644 --- a/test/DebugInfo/X86/generate-odr-hash.ll +++ b/test/DebugInfo/X86/generate-odr-hash.ll @@ -1,6 +1,6 @@ ; REQUIRES: object-emission -; RUN: llc %s -o %t -filetype=obj -O0 -generate-type-units -mtriple=x86_64-unknown-linux-gnu +; RUN: llc %s -o %t -filetype=obj -O0 -generate-type-units -generate-odr-hash -mtriple=x86_64-unknown-linux-gnu ; RUN: llvm-dwarfdump %t | FileCheck %s ; Generated from: @@ -46,31 +46,18 @@ ; CHECK-LABEL: .debug_info contents: ; CHECK: Compile Unit: length = [[CU_SIZE:[0-9a-f]+]] -; CHECK: DW_TAG_structure_type -; CHECK-NEXT: DW_AT_signature -; CHECK: DW_TAG_class_type -; CHECK-NEXT: DW_AT_signature - -; Ensure the CU-local type 'walrus' is not placed in a type unit. -; CHECK: DW_TAG_structure_type -; CHECK-NEXT: debug_str{{.*}}"walrus" -; CHECK-NEXT: DW_AT_byte_size -; CHECK-NEXT: DW_AT_decl_file -; CHECK-NEXT: DW_AT_decl_line - ; CHECK-LABEL: .debug_types contents: ; Check that we generate a hash for bar and the value. -; CHECK-NOT: type_signature -; CHECK-LABEL: type_signature = 0x1d02f3be30cc5688 +; CHECK-LABEL: type_signature = 0x6a7ee3d400662e88 +; CHECK: DW_AT_GNU_odr_signature [DW_FORM_data8] (0x200520c0d5b90eff) ; CHECK: DW_TAG_structure_type ; CHECK-NEXT: debug_str{{.*}}"bar" ; Check that we generate a hash for fluffy and the value. -; CHECK-NOT: type_signature -; CHECK-LABEL: type_signature = 0xb04af47397402e77 -; CHECK-NOT: DW_AT_GNU_odr_signature [DW_FORM_data8] (0x9a0124d5a0c21c52) +; CHECK-LABEL: type_signature = 0x139b2e1ea94afec7 +; CHECK: DW_AT_GNU_odr_signature [DW_FORM_data8] (0x9a0124d5a0c21c52) ; CHECK: DW_TAG_namespace ; CHECK-NEXT: debug_str{{.*}}"echidna" ; CHECK: DW_TAG_namespace @@ -80,22 +67,34 @@ ; CHECK: DW_TAG_class_type ; CHECK-NEXT: debug_str{{.*}}"fluffy" +; namespace and won't violate any ODR-ness. +; CHECK-LABEL: type_signature = 0xc0d031d6449dbca7 +; CHECK: DW_TAG_type_unit +; CHECK-NOT: NULL +; We emit no hash for walrus since the type is contained in an anonymous +; CHECK-NOT: DW_AT_GNU_odr_signature +; CHECK: DW_TAG_structure_type +; CHECK-NEXT: debug_str{{.*}}"walrus" +; CHECK-NEXT: DW_AT_byte_size +; CHECK-NEXT: DW_AT_decl_file +; CHECK-NEXT: DW_AT_decl_line +; CHECK: DW_TAG_subprogram + ; Check that we generate a hash for wombat and the value, but not for the ; anonymous type contained within. -; CHECK-NOT: type_signature -; CHECK-LABEL: type_signature = 0xfd756cee88f8a118 -; CHECK-NOT: DW_AT_GNU_odr_signature [DW_FORM_data8] (0x685bcc220141e9d7) +; CHECK-LABEL: type_signature = 0x73776f130648b986 +; CHECK: DW_AT_GNU_odr_signature [DW_FORM_data8] (0x685bcc220141e9d7) ; CHECK: DW_TAG_structure_type ; CHECK-NEXT: debug_str{{.*}}"wombat" -; CHECK-NOT: type_signature -; CHECK-LABEL: type_signature = 0xe94f6d3843e62d6b +; CHECK-LABEL: type_signature = 0xbf6fc40e82583d7c ; CHECK: DW_TAG_type_unit ; CHECK-NOT: NULL +; Check that we generate no ODR hash for the anonymous type nested inside 'wombat' ; CHECK-NOT: DW_AT_GNU_odr_signature ; CHECK: DW_TAG_structure_type ; The signature for the outer 'wombat' type -; CHECK: DW_AT_signature [DW_FORM_ref_sig8] (0xfd756cee88f8a118) +; CHECK: DW_AT_signature [DW_FORM_ref_sig8] (0x73776f130648b986) ; CHECK: DW_TAG_structure_type ; CHECK-NOT: DW_AT_name ; CHECK-NOT: DW_AT_GNU_odr_signature @@ -108,16 +107,18 @@ ; Don't emit pubtype entries for type DIEs in the compile unit that just indirect to a type unit. ; CHECK-NEXT: unit_size = [[CU_SIZE]] ; CHECK-NEXT: Offset Name -; CHECK-NEXT: "walrus" ; Type unit for 'bar' -; CHECK-NEXT: unit_size = 0x00000023 +; CHECK-NEXT: unit_size = 0x0000002b ; CHECK-NEXT: Offset Name ; CHECK-NEXT: "bar" -; CHECK-NEXT: unit_size = 0x0000005d +; CHECK-NEXT: unit_size = 0x00000065 ; CHECK-NEXT: Offset Name ; CHECK-NEXT: "int" ; CHECK-NEXT: "echidna::capybara::mongoose::fluffy" -; CHECK-NEXT: unit_size = 0x0000003a +; CHECK-NEXT: unit_size = 0x0000003b +; CHECK-NEXT: Offset Name +; CHECK-NEXT: "walrus" +; CHECK-NEXT: unit_size = 0x00000042 ; CHECK-NEXT: Offset Name ; CHECK-NEXT: "wombat" ; CHECK-NEXT: unit_size = 0x0000004b -- cgit v1.2.3