From 27c076ae40ec65d1a9462d41f3709b305e641fa1 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Fri, 16 May 2014 19:35:39 +0000 Subject: Fix most of PR10367. This patch changes the design of GlobalAlias so that it doesn't take a ConstantExpr anymore. It now points directly to a GlobalObject, but its type is independent of the aliasee type. To avoid changing all alias related tests in this patches, I kept the common syntax @foo = alias i32* @bar to mean the same as now. The cases that used to use cast now use the more general syntax @foo = alias i16, i32* @bar. Note that GlobalAlias now behaves a bit more like GlobalVariable. We know that its type is always a pointer, so we omit the '*'. For the bitcode, a nice surprise is that we were writing both identical types already, so the format change is minimal. Auto upgrade is handled by looking through the casts and no new fields are needed for now. New bitcode will simply have different types for Alias and Aliasee. One last interesting point in the patch is that replaceAllUsesWith becomes smart enough to avoid putting a ConstantExpr in the aliasee. This seems better than checking and updating every caller. A followup patch will delete getAliasedGlobal now that it is redundant. Another patch will add support for an explicit offset. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209007 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/Other/extract-alias.ll | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'test/Other') diff --git a/test/Other/extract-alias.ll b/test/Other/extract-alias.ll index d1e4af5456..dbc650ec69 100644 --- a/test/Other/extract-alias.ll +++ b/test/Other/extract-alias.ll @@ -14,7 +14,7 @@ ; DELETE: @zed = global i32 0 ; DELETE: @zeda0 = alias i32* @zed ; DELETE-NEXT: @a0foo = alias i32* ()* @foo -; DELETE-NEXT: @a0a0bar = alias void ()* @a0bar +; DELETE-NEXT: @a0a0bar = alias void ()* @bar ; DELETE-NEXT: @a0bar = alias void ()* @bar ; DELETE: declare i32* @foo() ; DELETE: define void @bar() { @@ -25,7 +25,7 @@ ; ALIAS: @zed = external global i32 ; ALIAS: @zeda0 = alias i32* @zed -; ALIASRE: @a0a0bar = alias void ()* @a0bar +; ALIASRE: @a0a0bar = alias void ()* @bar ; ALIASRE: @a0bar = alias void ()* @bar ; ALIASRE: declare void @bar() @@ -39,7 +39,7 @@ define i32* @foo() { ret i32* @zeda0 } -@a0a0bar = alias void ()* @a0bar +@a0a0bar = alias void ()* @bar @a0bar = alias void ()* @bar -- cgit v1.2.3