From 0a3368cde5e9e74c39c4be64f81d7c7ffa3480f6 Mon Sep 17 00:00:00 2001 From: Hal Finkel Date: Thu, 2 Jan 2014 20:47:09 +0000 Subject: [TableGen] Correctly generate implicit anonymous prototype defs in multiclasses Even within a multiclass, we had been generating concrete implicit anonymous defs when parsing values (generally in value lists). This behavior was incorrect, and led to errors when multiclass parameters were used in the parameter list of the implicit anonymous def. If we had some multiclass: multiclass mc { ... : SomeClass > The capture of the multiclass parameter 'n' would not work correctly, and depending on how the implicit SomeOtherClass was used, either TableGen would ignore something it shouldn't, or would crash. To fix this problem, when inside a multiclass, we generate prototype anonymous defs for implicit anonymous defs (just as we do for explicit anonymous defs). Within the multiclass, the current record prototype is populated with a node that is essentially: !cast(!strconcat(NAME, anon_value_name)). This is then resolved to the correct concrete anonymous def, in the usual way, when NAME is resolved during multiclass instantiation. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198348 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/TableGen/MultiClassDefName.td | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'test/TableGen') diff --git a/test/TableGen/MultiClassDefName.td b/test/TableGen/MultiClassDefName.td index 69b951d378..811d92667e 100644 --- a/test/TableGen/MultiClassDefName.td +++ b/test/TableGen/MultiClassDefName.td @@ -29,3 +29,13 @@ multiclass MC { defm : MC<"foo">; +multiclass MC2 { + def there : Outer >; +} + +// Ensure that we've correctly captured the reference to name from the implicit +// anonymous C def in the template parameter list of Outer. +// CHECK-NOT: MC2::name + +defm : MC2<"bar">; + -- cgit v1.2.3