From d1726a4580f3dc42e2debbfea41acb9e815c06be Mon Sep 17 00:00:00 2001 From: Eric Christopher Date: Mon, 12 Nov 2012 21:40:38 +0000 Subject: Rewrite DIContext interface to take an object. Update all callers. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@167757 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/llvm-symbolizer/llvm-symbolizer.cpp | 66 ++----------------------------- 1 file changed, 3 insertions(+), 63 deletions(-) (limited to 'tools/llvm-symbolizer') diff --git a/tools/llvm-symbolizer/llvm-symbolizer.cpp b/tools/llvm-symbolizer/llvm-symbolizer.cpp index f3e365981e..f3335a3fc3 100644 --- a/tools/llvm-symbolizer/llvm-symbolizer.cpp +++ b/tools/llvm-symbolizer/llvm-symbolizer.cpp @@ -170,18 +170,6 @@ typedef ModuleMapTy::iterator ModuleMapIter; static ModuleMapTy Modules; -static bool isFullNameOfDwarfSection(const StringRef &FullName, - const StringRef &ShortName) { - static const char kDwarfPrefix[] = "__DWARF,"; - StringRef Name = FullName; - // Skip "__DWARF," prefix. - if (Name.startswith(kDwarfPrefix)) - Name = Name.substr(strlen(kDwarfPrefix)); - // Skip . and _ prefixes. - Name = Name.substr(Name.find_first_not_of("._")); - return (Name == ShortName); -} - // Returns true if the object endianness is known. static bool getObjectEndianness(const ObjectFile *Obj, bool &IsLittleEndian) { @@ -190,41 +178,6 @@ static bool getObjectEndianness(const ObjectFile *Obj, return true; } -static void getDebugInfoSections(const ObjectFile *Obj, - StringRef &DebugInfoSection, - StringRef &DebugAbbrevSection, - StringRef &DebugLineSection, - StringRef &DebugArangesSection, - StringRef &DebugStringSection, - StringRef &DebugRangesSection) { - if (Obj == 0) - return; - error_code ec; - for (section_iterator i = Obj->begin_sections(), - e = Obj->end_sections(); - i != e; i.increment(ec)) { - if (error(ec)) break; - StringRef Name; - if (error(i->getName(Name))) continue; - StringRef Data; - if (error(i->getContents(Data))) continue; - if (isFullNameOfDwarfSection(Name, "debug_info")) - DebugInfoSection = Data; - else if (isFullNameOfDwarfSection(Name, "debug_abbrev")) - DebugAbbrevSection = Data; - else if (isFullNameOfDwarfSection(Name, "debug_line")) - DebugLineSection = Data; - // Don't use debug_aranges for now, as address ranges contained - // there may not cover all instructions in the module - // else if (isFullNameOfDwarfSection(Name, "debug_aranges")) - // DebugArangesSection = Data; - else if (isFullNameOfDwarfSection(Name, "debug_str")) - DebugStringSection = Data; - else if (isFullNameOfDwarfSection(Name, "debug_ranges")) - DebugRangesSection = Data; - } -} - static ObjectFile *getObjectFile(const std::string &Path) { OwningPtr Buff; MemoryBuffer::getFile(Path, Buff); @@ -246,6 +199,7 @@ static ModuleInfo *getOrCreateModuleInfo(const std::string &ModuleName) { return I->second; ObjectFile *Obj = getObjectFile(ModuleName); + ObjectFile *DbgObj = Obj; if (Obj == 0) { // Module name doesn't point to a valid object file. Modules.insert(make_pair(ModuleName, (ModuleInfo*)0)); @@ -255,15 +209,6 @@ static ModuleInfo *getOrCreateModuleInfo(const std::string &ModuleName) { DIContext *Context = 0; bool IsLittleEndian; if (getObjectEndianness(Obj, IsLittleEndian)) { - StringRef DebugInfo; - StringRef DebugAbbrev; - StringRef DebugLine; - StringRef DebugAranges; - StringRef DebugString; - StringRef DebugRanges; - getDebugInfoSections(Obj, DebugInfo, DebugAbbrev, DebugLine, - DebugAranges, DebugString, DebugRanges); - // On Darwin we may find DWARF in separate object file in // resource directory. if (isa(Obj)) { @@ -271,14 +216,9 @@ static ModuleInfo *getOrCreateModuleInfo(const std::string &ModuleName) { ModuleName); ObjectFile *ResourceObj = getObjectFile(ResourceName); if (ResourceObj != 0) - getDebugInfoSections(ResourceObj, DebugInfo, DebugAbbrev, DebugLine, - DebugAranges, DebugString, DebugRanges); + DbgObj = ResourceObj; } - - Context = DIContext::getDWARFContext( - IsLittleEndian, DebugInfo, DebugAbbrev, - DebugAranges, DebugLine, DebugString, - DebugRanges); + Context = DIContext::getDWARFContext(DbgObj); assert(Context); } -- cgit v1.2.3