From a8febf2283921157da1539c079cd74a55bf89a5a Mon Sep 17 00:00:00 2001 From: Hans Wennborg Date: Wed, 30 Apr 2014 16:25:02 +0000 Subject: ELFObjectWriter: deduplicate suffices in strtab We already do this for shstrtab, so might as well do it for strtab. This extracts the string table building code into a separate class. The idea is to use it for other object formats too. I mostly wanted to do this for the general principle, but it does save a little bit on object file size. I tried this on a clang bootstrap and saved 0.54% on the sum of object file sizes (1.14 MB out of 212 MB for a release build). Differential Revision: http://reviews.llvm.org/D3533 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@207670 91177308-0d34-0410-b5e6-96231b3b80d8 --- unittests/Object/CMakeLists.txt | 1 + unittests/Object/StringTableBuilderTest.cpp | 40 +++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) create mode 100644 unittests/Object/StringTableBuilderTest.cpp (limited to 'unittests') diff --git a/unittests/Object/CMakeLists.txt b/unittests/Object/CMakeLists.txt index 6dd66ce75b..580a894362 100644 --- a/unittests/Object/CMakeLists.txt +++ b/unittests/Object/CMakeLists.txt @@ -4,5 +4,6 @@ set(LLVM_LINK_COMPONENTS ) add_llvm_unittest(ObjectTests + StringTableBuilderTest.cpp YAMLTest.cpp ) diff --git a/unittests/Object/StringTableBuilderTest.cpp b/unittests/Object/StringTableBuilderTest.cpp new file mode 100644 index 0000000000..130eb4a3d7 --- /dev/null +++ b/unittests/Object/StringTableBuilderTest.cpp @@ -0,0 +1,40 @@ +//===----------- StringTableBuilderTest.cpp -------------------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "gtest/gtest.h" +#include "llvm/Object/StringTableBuilder.h" +#include + +using namespace llvm; + +namespace { + +TEST(StringTableBuilderTest, Basic) { + StringTableBuilder B; + + B.add("foo"); + B.add("bar"); + B.add("foobar"); + + B.finalize(); + + std::string Expected; + Expected += '\x00'; + Expected += "foobar"; + Expected += '\x00'; + Expected += "foo"; + Expected += '\x00'; + + EXPECT_EQ(Expected, B.data()); + EXPECT_EQ(1U, B.getOffset("foobar")); + EXPECT_EQ(4U, B.getOffset("bar")); + EXPECT_EQ(8U, B.getOffset("foo")); +} + +} -- cgit v1.2.3