From b3cb707f935560e40e2c1b15922910e6246cccf5 Mon Sep 17 00:00:00 2001 From: Filip Pizlo Date: Fri, 21 Feb 2014 03:17:31 +0000 Subject: This test was failing on non-X86-64 platforms because stackmaps only work on X86-64. Disable it on non-X86-64 platforms and add a comment. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@201838 91177308-0d34-0410-b5e6-96231b3b80d8 --- unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'unittests') diff --git a/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp b/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp index 7a7d178623..f6deb2f9b2 100644 --- a/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp +++ b/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp @@ -363,6 +363,10 @@ TEST_F(MCJITCAPITest, custom_memory_manager) { TEST_F(MCJITCAPITest, stackmap_creates_compact_unwind_on_darwin) { SKIP_UNSUPPORTED_PLATFORM; + // This test is also not supported on non-x86 platforms. + if (Triple(HostTriple).getArch() != Triple::x86_64) + return; + buildFunctionThatUsesStackmap(); buildMCJITOptions(); useRoundTripSectionMemoryManager(); @@ -378,6 +382,11 @@ TEST_F(MCJITCAPITest, stackmap_creates_compact_unwind_on_darwin) { EXPECT_EQ(42, functionPointer.usable()); EXPECT_TRUE(didCallAllocateCodeSection); + // Up to this point, the test is specific only to X86-64. But this next + // expectation is only valid on Darwin because it assumes that unwind + // data is made available only through compact_unwind. It would be + // worthwhile to extend this to handle non-Darwin platforms, in which + // case you'd want to look for an eh_frame or something. EXPECT_TRUE( Triple(HostTriple).getOS() != Triple::Darwin || didAllocateCompactUnwindSection); -- cgit v1.2.3