summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2008-03-13 04:33:03 +0000
committerChris Lattner <sabre@nondot.org>2008-03-13 04:33:03 +0000
commit041221c0972ff575b07f76808c504833d629ae1f (patch)
treef413ba84a11527b28bd0609ab30a40cc4a805b63
parent7520fcd7a5e4c17011588aab105dea9afa2ba3ec (diff)
downloadllvm-041221c0972ff575b07f76808c504833d629ae1f.tar.gz
llvm-041221c0972ff575b07f76808c504833d629ae1f.tar.bz2
llvm-041221c0972ff575b07f76808c504833d629ae1f.tar.xz
Various improvements suggested by Duncan
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@48325 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--include/llvm/Function.h4
-rw-r--r--include/llvm/Instructions.h10
-rw-r--r--include/llvm/ParameterAttributes.h4
-rw-r--r--lib/VMCore/ParameterAttributes.cpp2
4 files changed, 11 insertions, 9 deletions
diff --git a/include/llvm/Function.h b/include/llvm/Function.h
index 2ffd5eaacd..be7ea91049 100644
--- a/include/llvm/Function.h
+++ b/include/llvm/Function.h
@@ -144,10 +144,12 @@ public:
SubclassData = (SubclassData & 1) | (CC << 1);
}
- /// getParamAttrs - Return the parameter attributes for this function.
+ /// getParamAttrs - Return the parameter attributes for this Function.
+ ///
const PAListPtr &getParamAttrs() const { return ParamAttrs; }
/// setParamAttrs - Set the parameter attributes for this Function.
+ ///
void setParamAttrs(const PAListPtr &attrs) { ParamAttrs = attrs; }
/// hasCollector/getCollector/setCollector/clearCollector - The name of the
diff --git a/include/llvm/Instructions.h b/include/llvm/Instructions.h
index d29e11ca27..741153f288 100644
--- a/include/llvm/Instructions.h
+++ b/include/llvm/Instructions.h
@@ -926,11 +926,11 @@ public:
SubclassData = (SubclassData & 1) | (CC << 1);
}
- /// getParamAttrs - Return the PAListPtr for the parameter attributes of this
- /// call.
+ /// getParamAttrs - Return the parameter attributes for this call.
+ ///
const PAListPtr &getParamAttrs() const { return ParamAttrs; }
- /// setParamAttrs - Sets the parameter attributes for this CallInst.
+ /// setParamAttrs - Sets the parameter attributes for this call.
void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; }
/// @brief Determine whether the call or the callee has the given attribute.
@@ -1740,11 +1740,11 @@ public:
SubclassData = CC;
}
- /// getParamAttrs - Return the parameter attribute list for this invoke.
+ /// getParamAttrs - Return the parameter attributes for this invoke.
///
const PAListPtr &getParamAttrs() const { return ParamAttrs; }
- /// setParamAttrs - Set the parameter attribute list for this invoke.
+ /// setParamAttrs - Set the parameter attributes for this invoke.
///
void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; }
diff --git a/include/llvm/ParameterAttributes.h b/include/llvm/ParameterAttributes.h
index 4a68a7d7b6..5031d8467c 100644
--- a/include/llvm/ParameterAttributes.h
+++ b/include/llvm/ParameterAttributes.h
@@ -120,7 +120,7 @@ public:
static PAListPtr get(const ParamAttrsWithIndex *Attr, unsigned NumAttrs);
/// get - Return a ParamAttr list with the parameters specified by the
- /// consequtive random access iterator range.
+ /// consecutive random access iterator range.
template <typename Iter>
static PAListPtr get(const Iter &I, const Iter &E) {
if (I == E) return PAListPtr(); // Empty list.
@@ -161,7 +161,7 @@ public:
/// least one parameter or for the return value.
bool hasAttrSomewhere(ParameterAttributes Attr) const;
- /// operator< - Provide an ordering for parameter attribute lists.
+ /// operator==/!= - Provide equality predicates.
bool operator==(const PAListPtr &RHS) const { return PAList == RHS.PAList; }
bool operator!=(const PAListPtr &RHS) const { return PAList != RHS.PAList; }
diff --git a/lib/VMCore/ParameterAttributes.cpp b/lib/VMCore/ParameterAttributes.cpp
index 7501a35087..b5fb832fde 100644
--- a/lib/VMCore/ParameterAttributes.cpp
+++ b/lib/VMCore/ParameterAttributes.cpp
@@ -77,7 +77,7 @@ namespace llvm {
class ParamAttributeListImpl : public FoldingSetNode {
unsigned RefCount;
- // ParamAttrsList is uniqued, these should not be publicly available
+ // ParamAttrsList is uniqued, these should not be publicly available.
void operator=(const ParamAttributeListImpl &); // Do not implement
ParamAttributeListImpl(const ParamAttributeListImpl &); // Do not implement
~ParamAttributeListImpl(); // Private implementation