summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobias Grosser <grosser@fim.uni-passau.de>2013-07-02 03:28:10 +0000
committerTobias Grosser <grosser@fim.uni-passau.de>2013-07-02 03:28:10 +0000
commit068acc549547bebefd40e1dffb505d1a4477572d (patch)
tree7765bde3413114be66c1a82ca1ae7c0615545db0
parenta66aacf6d7e57b21dcd9e866d28749567cfba74b (diff)
downloadllvm-068acc549547bebefd40e1dffb505d1a4477572d.tar.gz
llvm-068acc549547bebefd40e1dffb505d1a4477572d.tar.bz2
llvm-068acc549547bebefd40e1dffb505d1a4477572d.tar.xz
IRVerifier: Correctly check attribute types
Add missing parenthesis such that all and not only the very first attribute is checked. Testing this piece of code is not possible with an LLVM-IR test file, as the LLVM-IR parser has a similar check such that the wrong IR does not even arrive at the verifier. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185408 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/IR/Verifier.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/IR/Verifier.cpp b/lib/IR/Verifier.cpp
index 7123eaf18a..8b4c1655d8 100644
--- a/lib/IR/Verifier.cpp
+++ b/lib/IR/Verifier.cpp
@@ -695,10 +695,11 @@ void Verifier::VerifyAttributeTypes(AttributeSet Attrs, unsigned Idx,
I->getKindAsEnum() == Attribute::Builtin ||
I->getKindAsEnum() == Attribute::NoBuiltin ||
I->getKindAsEnum() == Attribute::Cold) {
- if (!isFunction)
+ if (!isFunction) {
CheckFailed("Attribute '" + I->getAsString() +
"' only applies to functions!", V);
return;
+ }
} else if (isFunction) {
CheckFailed("Attribute '" + I->getAsString() +
"' does not apply to functions!", V);