diff options
| author | Dan Gohman <gohman@apple.com> | 2008-11-02 00:17:33 +0000 |
|---|---|---|
| committer | Dan Gohman <gohman@apple.com> | 2008-11-02 00:17:33 +0000 |
| commit | 21440acc06b6451ad5c0678e3f15ee08b1f1d206 (patch) | |
| tree | 35eaa0707239c0a269d3baf84082a56dfb0f10e0 | |
| parent | 3efcd4a65cdf41ec72205757421dca6026e92a19 (diff) | |
| download | llvm-21440acc06b6451ad5c0678e3f15ee08b1f1d206.tar.gz llvm-21440acc06b6451ad5c0678e3f15ee08b1f1d206.tar.bz2 llvm-21440acc06b6451ad5c0678e3f15ee08b1f1d206.tar.xz | |
Fix this recently moved code to use the correct type. CI is now a
ConstantInt, and SI is the original cast instruction. This fixes
PR2996.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@58549 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Transforms/Scalar/InstructionCombining.cpp | 4 | ||||
| -rw-r--r-- | test/Transforms/InstCombine/pr2996.ll | 12 |
2 files changed, 14 insertions, 2 deletions
diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 70b5aefa23..75a1ffea6b 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -8551,8 +8551,8 @@ Instruction *InstCombiner::visitSelectInstWithICmp(SelectInst &SI, In = InsertNewInstBefore(BinaryOperator::CreateAShr(In, Sh, In->getName()+".lobit"), *ICI); - if (In->getType() != CI->getType()) - In = CastInst::CreateIntegerCast(In, CI->getType(), + if (In->getType() != SI.getType()) + In = CastInst::CreateIntegerCast(In, SI.getType(), true/*SExt*/, "tmp", ICI); if (Pred == ICmpInst::ICMP_SGT) diff --git a/test/Transforms/InstCombine/pr2996.ll b/test/Transforms/InstCombine/pr2996.ll new file mode 100644 index 0000000000..3e7dfa2ba6 --- /dev/null +++ b/test/Transforms/InstCombine/pr2996.ll @@ -0,0 +1,12 @@ +; RUN: llvm-as < %s | opt -instcombine +; PR2996 + +define void @func_53(i16 signext %p_56) nounwind { +entry: + %0 = icmp sgt i16 %p_56, -1 ; <i1> [#uses=1] + %iftmp.0.0 = select i1 %0, i32 -1, i32 0 ; <i32> [#uses=1] + %1 = call i32 (...)* @func_4(i32 %iftmp.0.0) nounwind ; <i32> [#uses=0] + ret void +} + +declare i32 @func_4(...) |