diff options
author | Ed Maste <emaste@freebsd.org> | 2014-01-16 17:25:12 +0000 |
---|---|---|
committer | Ed Maste <emaste@freebsd.org> | 2014-01-16 17:25:12 +0000 |
commit | 22939fa0a4d8e139b14fb0d8c915bb45ce53600e (patch) | |
tree | 67ad1ed320c2eddcc82fb0e6b9e49103e6d70869 | |
parent | fbe67dabadafc38d4a55ceed03113c820860f8e0 (diff) | |
download | llvm-22939fa0a4d8e139b14fb0d8c915bb45ce53600e.tar.gz llvm-22939fa0a4d8e139b14fb0d8c915bb45ce53600e.tar.bz2 llvm-22939fa0a4d8e139b14fb0d8c915bb45ce53600e.tar.xz |
llvm-symbolizer: make mangled name heuristic apply to all symbols
PR: http://llvm.org/pr18431
Review: http://llvm-reviews.chandlerc.com/D2552
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199404 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | test/DebugInfo/Inputs/llvm-symbolizer-test.c | 18 | ||||
-rwxr-xr-x | test/DebugInfo/Inputs/llvm-symbolizer-test.elf-x86-64 | bin | 0 -> 10693 bytes | |||
-rw-r--r-- | test/DebugInfo/llvm-symbolizer.test | 11 | ||||
-rw-r--r-- | tools/llvm-symbolizer/LLVMSymbolize.cpp | 12 | ||||
-rw-r--r-- | tools/llvm-symbolizer/LLVMSymbolize.h | 1 |
5 files changed, 34 insertions, 8 deletions
diff --git a/test/DebugInfo/Inputs/llvm-symbolizer-test.c b/test/DebugInfo/Inputs/llvm-symbolizer-test.c new file mode 100644 index 0000000000..4c40c00c67 --- /dev/null +++ b/test/DebugInfo/Inputs/llvm-symbolizer-test.c @@ -0,0 +1,18 @@ +int f(int a, int b) { + return a + b; +} + +int g(int a) { + return a + 1; +} + + +int main() { + return f(2, g(2)); +} + +// Built with Clang 3.3: +// $ mkdir -p /tmp/dbginfo +// $ cp llvm-symbolizer-test.c /tmp/dbginfo +// $ cd /tmp/dbginfo +// $ clang -g llvm-symbolizer-test.c -o <output> diff --git a/test/DebugInfo/Inputs/llvm-symbolizer-test.elf-x86-64 b/test/DebugInfo/Inputs/llvm-symbolizer-test.elf-x86-64 Binary files differnew file mode 100755 index 0000000000..99a448a777 --- /dev/null +++ b/test/DebugInfo/Inputs/llvm-symbolizer-test.elf-x86-64 diff --git a/test/DebugInfo/llvm-symbolizer.test b/test/DebugInfo/llvm-symbolizer.test index 897cc3e0d5..d6e6e75442 100644 --- a/test/DebugInfo/llvm-symbolizer.test +++ b/test/DebugInfo/llvm-symbolizer.test @@ -66,3 +66,14 @@ RUN: | FileCheck %s --check-prefix=BINARY BINARY: main BINARY-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:16 BINARY: _start + +RUN: echo "0x400720" > %t.input5 +RUN: echo "0x4004a0" >> %t.input5 +RUN: echo "0x4006f0" >> %t.input5 +RUN: llvm-symbolizer --obj %p/Inputs/llvm-symbolizer-test.elf-x86-64 < %t.input5 \ +RUN: | FileCheck %s --check-prefix=BINARY_C + +BINARY_C: main +BINARY_C-NEXT: /tmp/dbginfo{{[/\\]}}llvm-symbolizer-test.c:10 +BINARY_C: _start +BINARY_C: {{g$}} diff --git a/tools/llvm-symbolizer/LLVMSymbolize.cpp b/tools/llvm-symbolizer/LLVMSymbolize.cpp index c522c0d3de..71588e171f 100644 --- a/tools/llvm-symbolizer/LLVMSymbolize.cpp +++ b/tools/llvm-symbolizer/LLVMSymbolize.cpp @@ -195,7 +195,7 @@ std::string LLVMSymbolizer::symbolizeData(const std::string &ModuleName, if (Opts.UseSymbolTable) { if (ModuleInfo *Info = getOrCreateModuleInfo(ModuleName)) { if (Info->symbolizeData(ModuleOffset, Name, Start, Size) && Opts.Demangle) - Name = DemangleGlobalName(Name); + Name = DemangleName(Name); } } std::stringstream ss; @@ -424,6 +424,10 @@ extern "C" char *__cxa_demangle(const char *mangled_name, char *output_buffer, std::string LLVMSymbolizer::DemangleName(const std::string &Name) { #if !defined(_MSC_VER) + // We can spoil names of symbols with C linkage, so use an heuristic + // approach to check if the name should be demangled. + if (Name.substr(0, 2) != "_Z") + return Name; int status = 0; char *DemangledName = __cxa_demangle(Name.c_str(), 0, 0, &status); if (status != 0) @@ -436,11 +440,5 @@ std::string LLVMSymbolizer::DemangleName(const std::string &Name) { #endif } -std::string LLVMSymbolizer::DemangleGlobalName(const std::string &Name) { - // We can spoil names of globals with C linkage, so use an heuristic - // approach to check if the name should be demangled. - return (Name.substr(0, 2) == "_Z") ? DemangleName(Name) : Name; -} - } // namespace symbolize } // namespace llvm diff --git a/tools/llvm-symbolizer/LLVMSymbolize.h b/tools/llvm-symbolizer/LLVMSymbolize.h index eb2666a542..03c765cc9c 100644 --- a/tools/llvm-symbolizer/LLVMSymbolize.h +++ b/tools/llvm-symbolizer/LLVMSymbolize.h @@ -71,7 +71,6 @@ private: ObjectFile *getObjectFileFromBinary(Binary *Bin, const std::string &ArchName); std::string printDILineInfo(DILineInfo LineInfo) const; - static std::string DemangleGlobalName(const std::string &Name); // Owns all the parsed binaries and object files. SmallVector<Binary*, 4> ParsedBinariesAndObjects; |