diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2012-02-18 03:29:25 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2012-02-18 03:29:25 +0000 |
| commit | 2c3acb0e273a50a9b4eeaf9d5544f6168bda85a6 (patch) | |
| tree | 6e06b73e59832b31e05af377740c1df7710edd8b | |
| parent | 5bfd9692089830da0d17f618a40f026a7600c67c (diff) | |
| download | llvm-2c3acb0e273a50a9b4eeaf9d5544f6168bda85a6.tar.gz llvm-2c3acb0e273a50a9b4eeaf9d5544f6168bda85a6.tar.bz2 llvm-2c3acb0e273a50a9b4eeaf9d5544f6168bda85a6.tar.xz | |
Fix a rather nasty regression from r150690: LHS != RHS does not imply LHS->stripPointerCasts() != RHS->stripPointerCasts().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@150863 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Analysis/InstructionSimplify.cpp | 3 | ||||
| -rw-r--r-- | test/Transforms/InstSimplify/compare.ll | 10 |
2 files changed, 12 insertions, 1 deletions
diff --git a/lib/Analysis/InstructionSimplify.cpp b/lib/Analysis/InstructionSimplify.cpp index 9d5b74c8cf..88a2c53e80 100644 --- a/lib/Analysis/InstructionSimplify.cpp +++ b/lib/Analysis/InstructionSimplify.cpp @@ -1593,10 +1593,11 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS, // the compare, and if only one of them is then we moved it to RHS already. Value *LHSPtr = LHS->stripPointerCasts(); Value *RHSPtr = RHS->stripPointerCasts(); + if (LHSPtr == RHSPtr) + return ConstantInt::get(ITy, CmpInst::isTrueWhenEqual(Pred)); if (isa<AllocaInst>(LHSPtr) && (isa<GlobalValue>(RHSPtr) || isa<AllocaInst>(RHSPtr) || isa<ConstantPointerNull>(RHSPtr))) - // We already know that LHS != RHS. return ConstantInt::get(ITy, CmpInst::isFalseWhenEqual(Pred)); // If we are comparing with zero then try hard since this is a common case. diff --git a/test/Transforms/InstSimplify/compare.ll b/test/Transforms/InstSimplify/compare.ll index 60f5990840..92b8fc7e3a 100644 --- a/test/Transforms/InstSimplify/compare.ll +++ b/test/Transforms/InstSimplify/compare.ll @@ -30,6 +30,16 @@ define i1 @gep() { ; CHECK-NEXT: ret i1 false } +define i1 @gep2() { +; CHECK: @gep2 + %a = alloca [3 x i8], align 8 + %x = getelementptr inbounds [3 x i8]* %a, i32 0, i32 0 + %y = getelementptr inbounds [3 x i8]* %a, i32 0, i32 0 + %cmp = icmp eq i8* %x, %y + ret i1 %cmp +; CHECK-NEXT: ret i1 true +} + define i1 @zext(i32 %x) { ; CHECK: @zext %e1 = zext i32 %x to i64 |