summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2006-12-09 23:14:08 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2006-12-09 23:14:08 +0000
commit3e69a7e527b85ccbc561824e63f8be12fcb5e6d6 (patch)
treef75ff50bbda12496e420c43d11c06f871546e157
parent5b2442637560becd2aca68a37cde31c122ae509d (diff)
downloadllvm-3e69a7e527b85ccbc561824e63f8be12fcb5e6d6.tar.gz
llvm-3e69a7e527b85ccbc561824e63f8be12fcb5e6d6.tar.bz2
llvm-3e69a7e527b85ccbc561824e63f8be12fcb5e6d6.tar.xz
fix test/Regression/CodeGen/X86/weak.ll
if a variable has no initialization, I->getInitializer() will fail git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@32407 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Target/X86/X86AsmPrinter.cpp2
-rw-r--r--test/CodeGen/X86/weak.ll3
2 files changed, 4 insertions, 1 deletions
diff --git a/lib/Target/X86/X86AsmPrinter.cpp b/lib/Target/X86/X86AsmPrinter.cpp
index 85a1cb6424..021e55c5c5 100644
--- a/lib/Target/X86/X86AsmPrinter.cpp
+++ b/lib/Target/X86/X86AsmPrinter.cpp
@@ -132,7 +132,7 @@ bool X86SharedAsmPrinter::doFinalization(Module &M) {
// Print out module-level global variables here.
for (Module::const_global_iterator I = M.global_begin(), E = M.global_end();
I != E; ++I) {
- if (!I->hasInitializer() && !I->hasExternalWeakLinkage())
+ if (!I->hasInitializer())
continue; // External global require no code
// Check to see if this is a special global used by LLVM, if so, emit it.
diff --git a/test/CodeGen/X86/weak.ll b/test/CodeGen/X86/weak.ll
new file mode 100644
index 0000000000..1397b191e4
--- /dev/null
+++ b/test/CodeGen/X86/weak.ll
@@ -0,0 +1,3 @@
+; RUN: llvm-upgrade < %s | llvm-as | llc -march=x86
+%a = extern_weak global int
+%b = global int* %a