diff options
| author | Chris Lattner <sabre@nondot.org> | 2009-02-05 06:55:21 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2009-02-05 06:55:21 +0000 |
| commit | 4798bbeaf5a76a83f2aa923b0abc792e01ac3be7 (patch) | |
| tree | 1b5714dc86be97b30c603fe42febc9890ed7e897 | |
| parent | 5734c94ec24a6f4ee940e0b146df48c647c7a4dc (diff) | |
| download | llvm-4798bbeaf5a76a83f2aa923b0abc792e01ac3be7.tar.gz llvm-4798bbeaf5a76a83f2aa923b0abc792e01ac3be7.tar.bz2 llvm-4798bbeaf5a76a83f2aa923b0abc792e01ac3be7.tar.xz | |
if we have a large GEP offset on a 32-bit or other target, make
sure to print the value properly sext'd to the right pointer size.
This fixes PR3481.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@63843 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 6 | ||||
| -rw-r--r-- | test/CodeGen/X86/2009-02-04-sext-i64-gep.ll | 9 |
2 files changed, 15 insertions, 0 deletions
diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index c6b0313c39..678488e1b4 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -815,6 +815,12 @@ void AsmPrinter::EmitConstantValueOnly(const Constant *CV) { SmallVector<Value*, 8> idxVec(CE->op_begin()+1, CE->op_end()); if (int64_t Offset = TD->getIndexedOffset(ptrVal->getType(), &idxVec[0], idxVec.size())) { + // Truncate/sext the offset to the pointer size. + if (TD->getPointerSizeInBits() != 64) { + int SExtAmount = 64-TD->getPointerSizeInBits(); + Offset = (Offset << SExtAmount) >> SExtAmount; + } + if (Offset) O << '('; EmitConstantValueOnly(ptrVal); diff --git a/test/CodeGen/X86/2009-02-04-sext-i64-gep.ll b/test/CodeGen/X86/2009-02-04-sext-i64-gep.ll new file mode 100644 index 0000000000..1f29bdbe37 --- /dev/null +++ b/test/CodeGen/X86/2009-02-04-sext-i64-gep.ll @@ -0,0 +1,9 @@ +; RUN: llvm-as < %s | llc | grep { - 92} +; PR3481 +; The offset should print as -92, not +17179869092 + +target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:32:32" +target triple = "i386-pc-linux-gnu" +@p = common global [10 x i32] zeroinitializer, align 4 ; <[10 x i32]*> +@g = global [1 x i32*] [ i32* bitcast (i8* getelementptr (i8* bitcast +([10 x i32]* @p to i8*), i64 17179869092) to i32*) ], align 4 |