diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2013-07-08 15:22:09 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2013-07-08 15:22:09 +0000 |
commit | 73e97d0f48cf9ed3093019064f6340617ac8de9e (patch) | |
tree | 00f7f2531f64a4f850f0c6f636f52d06016b149e | |
parent | 19d2b78978905cfde0a0d7190c8480219fb2d1c6 (diff) | |
download | llvm-73e97d0f48cf9ed3093019064f6340617ac8de9e.tar.gz llvm-73e97d0f48cf9ed3093019064f6340617ac8de9e.tar.bz2 llvm-73e97d0f48cf9ed3093019064f6340617ac8de9e.tar.xz |
Create files with the correct permission instead of changing it afterwards.
Not intended functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185830 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Support/FileOutputBuffer.cpp | 29 |
1 files changed, 7 insertions, 22 deletions
diff --git a/lib/Support/FileOutputBuffer.cpp b/lib/Support/FileOutputBuffer.cpp index fbfda317e7..ed084faed7 100644 --- a/lib/Support/FileOutputBuffer.cpp +++ b/lib/Support/FileOutputBuffer.cpp @@ -62,11 +62,16 @@ error_code FileOutputBuffer::create(StringRef FilePath, if (EC) return EC; + unsigned Mode = sys::fs::all_read | sys::fs::all_write; + // If requested, make the output file executable. + if (Flags & F_executable) + Mode |= sys::fs::all_exe; + // Create new file in same directory but with random name. SmallString<128> TempFilePath; int FD; - EC = sys::fs::createUniqueFile(Twine(FilePath) + ".tmp%%%%%%%", - FD, TempFilePath); + EC = sys::fs::createUniqueFile(Twine(FilePath) + ".tmp%%%%%%%", FD, + TempFilePath, Mode); if (EC) return EC; @@ -75,26 +80,6 @@ error_code FileOutputBuffer::create(StringRef FilePath, if (EC) return EC; - // If requested, make the output file executable. - if ( Flags & F_executable ) { - sys::fs::file_status Stat2; - EC = sys::fs::status(Twine(TempFilePath), Stat2); - if (EC) - return EC; - - sys::fs::perms new_perms = Stat2.permissions(); - if ( new_perms & sys::fs::owner_read ) - new_perms |= sys::fs::owner_exe; - if ( new_perms & sys::fs::group_read ) - new_perms |= sys::fs::group_exe; - if ( new_perms & sys::fs::others_read ) - new_perms |= sys::fs::others_exe; - new_perms |= sys::fs::add_perms; - EC = sys::fs::permissions(Twine(TempFilePath), new_perms); - if (EC) - return EC; - } - Result.reset(new FileOutputBuffer(MappedFile.get(), FilePath, TempFilePath)); if (Result) MappedFile.take(); |