summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYunzhong Gao <Yunzhong_Gao@playstation.sony.com>2013-12-03 18:05:14 +0000
committerYunzhong Gao <Yunzhong_Gao@playstation.sony.com>2013-12-03 18:05:14 +0000
commit822a02fb4c3a044becbce2aed751702b5ec16855 (patch)
treeeebb9f78765fcbca5920bad0a5c475fd34144717
parentdf9c9da88402e393343d5e199b0ebaa681b3a1ce (diff)
downloadllvm-822a02fb4c3a044becbce2aed751702b5ec16855.tar.gz
llvm-822a02fb4c3a044becbce2aed751702b5ec16855.tar.bz2
llvm-822a02fb4c3a044becbce2aed751702b5ec16855.tar.xz
Teach the internalize pass to skip dllexported symbols because they could be
referenced in a way that even the linker does not see. Differential Revision: http://llvm-reviews.chandlerc.com/D2280 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@196300 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Transforms/IPO/Internalize.cpp4
-rw-r--r--test/Transforms/Internalize/lists.ll9
2 files changed, 13 insertions, 0 deletions
diff --git a/lib/Transforms/IPO/Internalize.cpp b/lib/Transforms/IPO/Internalize.cpp
index 962d3de315..dae69ce091 100644
--- a/lib/Transforms/IPO/Internalize.cpp
+++ b/lib/Transforms/IPO/Internalize.cpp
@@ -115,6 +115,10 @@ static bool shouldInternalize(const GlobalValue &GV,
if (GV.hasAvailableExternallyLinkage())
return false;
+ // Assume that dllexported symbols are referenced elsewhere
+ if (GV.hasDLLExportLinkage())
+ return false;
+
// Already has internal linkage
if (GV.hasLocalLinkage())
return false;
diff --git a/test/Transforms/Internalize/lists.ll b/test/Transforms/Internalize/lists.ll
index 83e441a2df..637d701524 100644
--- a/test/Transforms/Internalize/lists.ll
+++ b/test/Transforms/Internalize/lists.ll
@@ -48,3 +48,12 @@ define void @foo() {
define available_externally void @bar() {
ret void
}
+
+; ALL: define dllexport void @export_foo() {
+; FOO_AND_J: define dllexport void @export_foo() {
+; FOO_AND_BAR: define dllexport void @export_foo() {
+; FOO_J_AND_BAR: define dllexport void @export_foo() {
+define dllexport void @export_foo() {
+ ret void
+}
+