diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-05-08 15:26:12 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-05-08 15:26:12 +0000 |
commit | c9727ea1c344bc02b0abd490f5591f314827f9fb (patch) | |
tree | 2a220fac6df9a2f19782d70279f22ba73e1fb12b /lib/CodeGen/CodeGenModule.cpp | |
parent | 48c83f72e7034e970c6be5b02ee23dd3596b1e5f (diff) | |
download | clang-c9727ea1c344bc02b0abd490f5591f314827f9fb.tar.gz clang-c9727ea1c344bc02b0abd490f5591f314827f9fb.tar.bz2 clang-c9727ea1c344bc02b0abd490f5591f314827f9fb.tar.xz |
Cleanup setFunctionDefinitionAttributes.
Use more specific type, update comments and name style.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@208328 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/CodeGenModule.cpp')
-rw-r--r-- | lib/CodeGen/CodeGenModule.cpp | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp index 22ff2081c6..cdd240ee2a 100644 --- a/lib/CodeGen/CodeGenModule.cpp +++ b/lib/CodeGen/CodeGenModule.cpp @@ -594,14 +594,9 @@ CodeGenModule::getFunctionLinkage(GlobalDecl GD) { UseThunkForDtorVariant); } - -/// SetFunctionDefinitionAttributes - Set attributes for a global. -/// -/// FIXME: This is currently only done for aliases and functions, but not for -/// variables (these details are set in EmitGlobalVarDefinition for variables). -void CodeGenModule::SetFunctionDefinitionAttributes(const FunctionDecl *D, - llvm::GlobalValue *GV) { - setNonAliasAttributes(D, GV); +void CodeGenModule::setFunctionDefinitionAttributes(const FunctionDecl *D, + llvm::Function *F) { + setNonAliasAttributes(D, F); } void CodeGenModule::SetLLVMFunctionAttributes(const Decl *D, @@ -2247,14 +2242,14 @@ void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD, llvm::Function *Fn = cast<llvm::Function>(GV); setFunctionLinkage(GD, Fn); - // FIXME: this is redundant with part of SetFunctionDefinitionAttributes + // FIXME: this is redundant with part of setFunctionDefinitionAttributes setGlobalVisibility(Fn, D); MaybeHandleStaticInExternC(D, Fn); CodeGenFunction(*this).GenerateCode(D, Fn, FI); - SetFunctionDefinitionAttributes(D, Fn); + setFunctionDefinitionAttributes(D, Fn); SetLLVMFunctionAttributesForDefinition(D, Fn); if (const ConstructorAttr *CA = D->getAttr<ConstructorAttr>()) |