diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2012-06-20 09:53:52 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2012-06-20 09:53:52 +0000 |
| commit | f95d4125c01fa7b98722ae8cfbceac4a87d037b4 (patch) | |
| tree | 5d3f7163adeadbff7ac65afff4414f6757b06792 /tools/clang-check | |
| parent | 10663399b1d4663e8b140eb12d9aa351be147c55 (diff) | |
| download | clang-f95d4125c01fa7b98722ae8cfbceac4a87d037b4.tar.gz clang-f95d4125c01fa7b98722ae8cfbceac4a87d037b4.tar.bz2 clang-f95d4125c01fa7b98722ae8cfbceac4a87d037b4.tar.xz | |
Fix a big layering violation introduced by r158771.
That commit added a new library just to hold the RawCommentList. I've
started a discussion on the commit thread about whether that is really
meritted -- it certainly doesn't seem necessary at this stage.
However, the immediate problem is that the AST library has a hard
dependency on the Comment library, but the dependencies were set up
completely backward. In addition to the layering violation, this had an
unfortunate effect if scattering the Comments library dependency
throughout the build system, but inconsistently so -- several parts of
the CMake dependencies were missing and only showed up due to transitive
deps or the fact that the target wasn't being built by tho bots.
It turns out that the Comments library can't (currently) be a well
formed layer *below* the AST library either, as it has an API that
accepts an ASTContext. That parameter is currently unused, so maybe that
was a mistake?
Anyways, it really seems like this is logically part of the AST --
that's the whole point of the ASTContext providing access to it as far
as I can tell -- so I've merged it into the AST library to solve the
immediate layering violation problems and remove some of the churn from
our library dependencies.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@158807 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools/clang-check')
| -rw-r--r-- | tools/clang-check/CMakeLists.txt | 2 | ||||
| -rw-r--r-- | tools/clang-check/Makefile | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tools/clang-check/CMakeLists.txt b/tools/clang-check/CMakeLists.txt index 83fe10f80e..851d6cdd16 100644 --- a/tools/clang-check/CMakeLists.txt +++ b/tools/clang-check/CMakeLists.txt @@ -1,4 +1,4 @@ -set(LLVM_USED_LIBS clangTooling clangBasic clangComments) +set(LLVM_USED_LIBS clangTooling clangBasic) add_clang_executable(clang-check ClangCheck.cpp diff --git a/tools/clang-check/Makefile b/tools/clang-check/Makefile index 5c54a6b332..49b1ada95b 100644 --- a/tools/clang-check/Makefile +++ b/tools/clang-check/Makefile @@ -18,7 +18,7 @@ TOOL_NO_EXPORTS = 1 LINK_COMPONENTS := support mc USEDLIBS = clangFrontend.a clangSerialization.a clangDriver.a \ clangTooling.a clangParse.a clangSema.a clangAnalysis.a \ - clangEdit.a clangAST.a clangLex.a clangComments.a clangBasic.a + clangEdit.a clangAST.a clangLex.a clangBasic.a include $(CLANG_LEVEL)/Makefile |