diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2011-03-22 19:20:47 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2011-03-22 19:20:47 +0000 |
commit | 11d1803770f54dad441007a6ebafc70cb9395695 (patch) | |
tree | b4f740d419bebe0722cb6c5d01970c9ae65bc2e5 | |
parent | c1dbd5d9c30ea67ae45f190ff90e076cdf8bbc17 (diff) | |
download | llvm-11d1803770f54dad441007a6ebafc70cb9395695.tar.gz llvm-11d1803770f54dad441007a6ebafc70cb9395695.tar.bz2 llvm-11d1803770f54dad441007a6ebafc70cb9395695.tar.xz |
We don't need a null terminator for the output file.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@128098 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | include/llvm/Support/MemoryBuffer.h | 6 | ||||
-rw-r--r-- | lib/Support/MemoryBuffer.cpp | 12 | ||||
-rw-r--r-- | tools/lto/LTOCodeGenerator.cpp | 5 |
3 files changed, 16 insertions, 7 deletions
diff --git a/include/llvm/Support/MemoryBuffer.h b/include/llvm/Support/MemoryBuffer.h index 3006367a5a..9a2aff04c7 100644 --- a/include/llvm/Support/MemoryBuffer.h +++ b/include/llvm/Support/MemoryBuffer.h @@ -64,10 +64,12 @@ public: /// specified, this means that the client knows that the file exists and that /// it has the specified size. static error_code getFile(StringRef Filename, OwningPtr<MemoryBuffer> &result, - int64_t FileSize = -1); + int64_t FileSize = -1, + bool RequiresNullTerminator = true); static error_code getFile(const char *Filename, OwningPtr<MemoryBuffer> &result, - int64_t FileSize = -1); + int64_t FileSize = -1, + bool RequiresNullTerminator = true); /// getOpenFile - Given an already-open file descriptor, read the file and /// return a MemoryBuffer. diff --git a/lib/Support/MemoryBuffer.cpp b/lib/Support/MemoryBuffer.cpp index c08e91a382..ea72720b7f 100644 --- a/lib/Support/MemoryBuffer.cpp +++ b/lib/Support/MemoryBuffer.cpp @@ -196,15 +196,18 @@ public: error_code MemoryBuffer::getFile(StringRef Filename, OwningPtr<MemoryBuffer> &result, - int64_t FileSize) { + int64_t FileSize, + bool RequiresNullTerminator) { // Ensure the path is null terminated. SmallString<256> PathBuf(Filename.begin(), Filename.end()); - return MemoryBuffer::getFile(PathBuf.c_str(), result, FileSize); + return MemoryBuffer::getFile(PathBuf.c_str(), result, FileSize, + RequiresNullTerminator); } error_code MemoryBuffer::getFile(const char *Filename, OwningPtr<MemoryBuffer> &result, - int64_t FileSize) { + int64_t FileSize, + bool RequiresNullTerminator) { int OpenFlags = O_RDONLY; #ifdef O_BINARY OpenFlags |= O_BINARY; // Open input file in binary mode on win32. @@ -213,7 +216,8 @@ error_code MemoryBuffer::getFile(const char *Filename, if (FD == -1) { return error_code(errno, posix_category()); } - error_code ret = getOpenFile(FD, Filename, result, FileSize); + error_code ret = getOpenFile(FD, Filename, result, FileSize, FileSize, + 0, RequiresNullTerminator); close(FD); return ret; } diff --git a/tools/lto/LTOCodeGenerator.cpp b/tools/lto/LTOCodeGenerator.cpp index ffe244dbcd..372cb31a4c 100644 --- a/tools/lto/LTOCodeGenerator.cpp +++ b/tools/lto/LTOCodeGenerator.cpp @@ -209,8 +209,11 @@ const void* LTOCodeGenerator::compile(size_t* length, std::string& errMsg) // read .o file into memory buffer OwningPtr<MemoryBuffer> BuffPtr; - if (error_code ec = MemoryBuffer::getFile(uniqueObjStr.c_str(),BuffPtr)) + if (error_code ec = MemoryBuffer::getFile(uniqueObjStr.c_str(), BuffPtr, + -1, false)) { errMsg = ec.message(); + return NULL; + } _nativeObjectFile = BuffPtr.take(); // remove temp files |