diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2009-12-18 20:35:38 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2009-12-18 20:35:38 +0000 |
commit | 1cefd7cd07c5e4113a1dcabf834cbcb6026e42dd (patch) | |
tree | a8a7833d4967ae07d9a86c0783c78d2b45eab127 | |
parent | b742defa0a8f3e477c3ed641da49aab276937556 (diff) | |
download | llvm-1cefd7cd07c5e4113a1dcabf834cbcb6026e42dd.tar.gz llvm-1cefd7cd07c5e4113a1dcabf834cbcb6026e42dd.tar.bz2 llvm-1cefd7cd07c5e4113a1dcabf834cbcb6026e42dd.tar.xz |
Catch more cases of a pointer being marked garbage twice. This helps when
debugging some leaks (PR5770 in particular).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@91713 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/VMCore/LeaksContext.h | 3 | ||||
-rw-r--r-- | unittests/Support/LeakDetectorTest.cpp | 29 |
2 files changed, 31 insertions, 1 deletions
diff --git a/lib/VMCore/LeaksContext.h b/lib/VMCore/LeaksContext.h index bd10a479ae..abff090b87 100644 --- a/lib/VMCore/LeaksContext.h +++ b/lib/VMCore/LeaksContext.h @@ -46,8 +46,9 @@ struct LeakDetectorImpl { // immediately, it is added to the CachedValue Value. If it is // immediately removed, no set search need be performed. void addGarbage(const T* o) { + assert(Ts.count(o) == 0 && "Object already in set!"); if (Cache) { - assert(Ts.count(Cache) == 0 && "Object already in set!"); + assert(Cache != o && "Object already in set!"); Ts.insert(Cache); } Cache = o; diff --git a/unittests/Support/LeakDetectorTest.cpp b/unittests/Support/LeakDetectorTest.cpp new file mode 100644 index 0000000000..85ef04676d --- /dev/null +++ b/unittests/Support/LeakDetectorTest.cpp @@ -0,0 +1,29 @@ +//===- llvm/unittest/LeakDetector/LeakDetector.cpp - LeakDetector tests ---===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "gtest/gtest.h" +#include "llvm/Support/LeakDetector.h" + +using namespace llvm; + +namespace { + +#ifdef GTEST_HAS_DEATH_TEST +TEST(LeakDetector, Death1) { + LeakDetector::addGarbageObject((void*) 1); + LeakDetector::addGarbageObject((void*) 2); + + EXPECT_DEATH(LeakDetector::addGarbageObject((void*) 1), + ".*Ts.count\\(o\\) == 0 && \"Object already in set!\""); + EXPECT_DEATH(LeakDetector::addGarbageObject((void*) 2), + "Cache != o && \"Object already in set!\""); +} +#endif + +} |