summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVictor Hernandez <vhernandez@apple.com>2010-01-22 19:05:05 +0000
committerVictor Hernandez <vhernandez@apple.com>2010-01-22 19:05:05 +0000
commit29fa5e98863332eb808a6f5c1e29138ca6fd7f5c (patch)
tree0d7fd1a64b457729c98dd969ffd65df74aaf85d0
parent7481ae657232b2f9275be4be8f03d8d75a12dde3 (diff)
downloadllvm-29fa5e98863332eb808a6f5c1e29138ca6fd7f5c.tar.gz
llvm-29fa5e98863332eb808a6f5c1e29138ca6fd7f5c.tar.bz2
llvm-29fa5e98863332eb808a6f5c1e29138ca6fd7f5c.tar.xz
Keep ignoring pointer-to-pointer bitcasts
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94194 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp12
-rw-r--r--lib/Transforms/Utils/PromoteMemoryToRegister.cpp3
2 files changed, 8 insertions, 7 deletions
diff --git a/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp b/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
index 91219c45ad..ae728ddecf 100644
--- a/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
+++ b/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
@@ -406,8 +406,10 @@ Instruction *InstCombiner::visitStoreInst(StoreInst &SI) {
for (unsigned ScanInsts = 6; BBI != SI.getParent()->begin() && ScanInsts;
--ScanInsts) {
--BBI;
- // Don't count debug info directives, lest they affect codegen
- if (isa<DbgInfoIntrinsic>(BBI)) {
+ // Don't count debug info directives, lest they affect codegen,
+ // and we skip pointer-to-pointer bitcasts, which are NOPs.
+ if (isa<DbgInfoIntrinsic>(BBI) ||
+ (isa<BitCastInst>(BBI) && isa<PointerType>(BBI->getType()))) {
ScanInsts++;
continue;
}
@@ -476,7 +478,8 @@ Instruction *InstCombiner::visitStoreInst(StoreInst &SI) {
BBI = &SI;
do {
++BBI;
- } while (isa<DbgInfoIntrinsic>(BBI));
+ } while (isa<DbgInfoIntrinsic>(BBI) ||
+ (isa<BitCastInst>(BBI) && isa<PointerType>(BBI->getType())));
if (BranchInst *BI = dyn_cast<BranchInst>(BBI))
if (BI->isUnconditional())
if (SimplifyStoreAtEndOfBlock(SI))
@@ -536,7 +539,8 @@ bool InstCombiner::SimplifyStoreAtEndOfBlock(StoreInst &SI) {
if (OtherBr->isUnconditional()) {
--BBI;
// Skip over debugging info.
- while (isa<DbgInfoIntrinsic>(BBI)) {
+ while (isa<DbgInfoIntrinsic>(BBI) ||
+ (isa<BitCastInst>(BBI) && isa<PointerType>(BBI->getType()))) {
if (BBI==OtherBB->begin())
return false;
--BBI;
diff --git a/lib/Transforms/Utils/PromoteMemoryToRegister.cpp b/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
index 291d320636..9fdcfe5ec3 100644
--- a/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
+++ b/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
@@ -76,9 +76,6 @@ bool llvm::isAllocaPromotable(const AllocaInst *AI) {
return false; // Don't allow a store OF the AI, only INTO the AI.
if (SI->isVolatile())
return false;
- } else if (isa<BitCastInst>(*UI)) {
- // A bitcast inhibits promotion.
- return false;
} else {
return false;
}