diff options
| author | Victor Hernandez <vhernandez@apple.com> | 2010-01-20 06:57:02 +0000 |
|---|---|---|
| committer | Victor Hernandez <vhernandez@apple.com> | 2010-01-20 06:57:02 +0000 |
| commit | 3bcda49b35497557676647972bf36f70bb6946f1 (patch) | |
| tree | 4fb72607d7aa2a5a238f217873f48444328b878e | |
| parent | acf1831596ca09eab5a1f7bca804c2745c6f5f92 (diff) | |
| download | llvm-3bcda49b35497557676647972bf36f70bb6946f1.tar.gz llvm-3bcda49b35497557676647972bf36f70bb6946f1.tar.bz2 llvm-3bcda49b35497557676647972bf36f70bb6946f1.tar.xz | |
Fix/strengthen verification of llvm.dbg.declare
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93990 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/VMCore/Verifier.cpp | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/lib/VMCore/Verifier.cpp b/lib/VMCore/Verifier.cpp index 91517ea7f6..6e47348995 100644 --- a/lib/VMCore/Verifier.cpp +++ b/lib/VMCore/Verifier.cpp @@ -1581,7 +1581,7 @@ void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) { // If the intrinsic takes MDNode arguments, verify that they are either global // or are local to *this* function. - for (unsigned i = 0, e = CI.getNumOperands(); i != e; ++i) + for (unsigned i = 1, e = CI.getNumOperands(); i != e; ++i) if (MDNode *MD = dyn_cast<MDNode>(CI.getOperand(i))) { if (!MD->isFunctionLocal()) continue; SmallPtrSet<MDNode *, 32> Visited; @@ -1591,12 +1591,17 @@ void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) { switch (ID) { default: break; - case Intrinsic::dbg_declare: // llvm.dbg.declare - if (MDNode *MD = dyn_cast<MDNode>(CI.getOperand(1))) + case Intrinsic::dbg_declare: { // llvm.dbg.declare + Assert1(CI.getOperand(1) && isa<MDNode>(CI.getOperand(1)), + "invalid llvm.dbg.declare intrinsic call", &CI); + MDNode *MD = cast<MDNode>(CI.getOperand(1)); + Assert1(MD->getNumOperands() == 1, + "invalid llvm.dbg.declare intrinsic call", &CI); + if (MD->getOperand(0)) if (Constant *C = dyn_cast<Constant>(MD->getOperand(0))) Assert1(C && !isa<ConstantPointerNull>(C), "invalid llvm.dbg.declare intrinsic call", &CI); - break; + } break; case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: |