diff options
| author | Chris Lattner <sabre@nondot.org> | 2010-10-03 19:09:13 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2010-10-03 19:09:13 +0000 |
| commit | 591d76ea5a10062316e18075eccd4c62d60b5a80 (patch) | |
| tree | c9d1af50a2ce930dc86e8ea830e0ed222b5b6e39 | |
| parent | 0febc4657b0edbf16b55ca5365d2b6aab45be7c5 (diff) | |
| download | llvm-591d76ea5a10062316e18075eccd4c62d60b5a80.tar.gz llvm-591d76ea5a10062316e18075eccd4c62d60b5a80.tar.bz2 llvm-591d76ea5a10062316e18075eccd4c62d60b5a80.tar.xz | |
the immediate field of pshufw is actually an 8-bit field, not a 8-bit field that is sign extended. This fixes PR8288
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@115473 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | include/llvm/IntrinsicsX86.td | 2 | ||||
| -rw-r--r-- | lib/Target/X86/X86InstrMMX.td | 4 | ||||
| -rw-r--r-- | test/MC/X86/x86-32.s | 5 |
3 files changed, 8 insertions, 3 deletions
diff --git a/include/llvm/IntrinsicsX86.td b/include/llvm/IntrinsicsX86.td index 8650bbc8c7..2b18e7fa4b 100644 --- a/include/llvm/IntrinsicsX86.td +++ b/include/llvm/IntrinsicsX86.td @@ -631,7 +631,7 @@ let TargetPrefix = "x86" in { // All intrinsics start with "llvm.x86.". Intrinsic<[llvm_v16i8_ty], [llvm_v16i8_ty, llvm_v16i8_ty], [IntrNoMem]>; def int_x86_ssse3_pshuf_w : GCCBuiltin<"__builtin_ia32_pshufw">, - Intrinsic<[llvm_x86mmx_ty], [llvm_x86mmx_ty, llvm_i32_ty], + Intrinsic<[llvm_x86mmx_ty], [llvm_x86mmx_ty, llvm_i8_ty], [IntrNoMem]>; } diff --git a/lib/Target/X86/X86InstrMMX.td b/lib/Target/X86/X86InstrMMX.td index 99e749a58e..c78099eca4 100644 --- a/lib/Target/X86/X86InstrMMX.td +++ b/lib/Target/X86/X86InstrMMX.td @@ -339,12 +339,12 @@ defm MMX_PACKUSWB : MMXI_binop_rm_int<0x67, "packuswb", int_x86_mmx_packuswb>; defm MMX_PSHUFB : SS3I_binop_rm_int_mm<0x00, "pshufb", int_x86_ssse3_pshuf_b>; def MMX_PSHUFWri : MMXIi8<0x70, MRMSrcReg, - (outs VR64:$dst), (ins VR64:$src1, i32i8imm:$src2), + (outs VR64:$dst), (ins VR64:$src1, i8imm:$src2), "pshufw\t{$src2, $src1, $dst|$dst, $src1, $src2}", [(set VR64:$dst, (int_x86_ssse3_pshuf_w VR64:$src1, imm:$src2))]>; def MMX_PSHUFWmi : MMXIi8<0x70, MRMSrcMem, - (outs VR64:$dst), (ins i64mem:$src1, i32i8imm:$src2), + (outs VR64:$dst), (ins i64mem:$src1, i8imm:$src2), "pshufw\t{$src2, $src1, $dst|$dst, $src1, $src2}", [(set VR64:$dst, (int_x86_ssse3_pshuf_w (load_mmx addr:$src1), diff --git a/test/MC/X86/x86-32.s b/test/MC/X86/x86-32.s index b2422847b2..2391028fee 100644 --- a/test/MC/X86/x86-32.s +++ b/test/MC/X86/x86-32.s @@ -585,3 +585,8 @@ ljmp $0x7ace,$0x7ace // CHECK: pshufw $14, %mm4, %mm0 # encoding: [0x0f,0x70,0xc4,0x0e] pshufw $14, %mm4, %mm0 + +// CHECK: pshufw $90, %mm4, %mm0 # encoding: [0x0f,0x70,0xc4,0x5a] +// PR8288 +pshufw $90, %mm4, %mm0 + |