diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2013-09-04 15:33:34 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2013-09-04 15:33:34 +0000 |
| commit | 9127334dade7fa36cb5cb999fc116ceaa4f52ac9 (patch) | |
| tree | 5bde247814483e267c07c6605c5f2f594b9e0e79 | |
| parent | bf34f346420dbcdb3f9376967bde701682471a79 (diff) | |
| download | llvm-9127334dade7fa36cb5cb999fc116ceaa4f52ac9.tar.gz llvm-9127334dade7fa36cb5cb999fc116ceaa4f52ac9.tar.bz2 llvm-9127334dade7fa36cb5cb999fc116ceaa4f52ac9.tar.xz | |
Error on linking appending globals with different unnamed_addr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@189950 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Linker/LinkModules.cpp | 6 | ||||
| -rw-r--r-- | test/Linker/unnamed-addr-err-a.ll | 4 | ||||
| -rw-r--r-- | test/Linker/unnamed-addr-err-b.ll | 4 |
3 files changed, 13 insertions, 1 deletions
diff --git a/lib/Linker/LinkModules.cpp b/lib/Linker/LinkModules.cpp index 16e2851f0b..4fffa55fe4 100644 --- a/lib/Linker/LinkModules.cpp +++ b/lib/Linker/LinkModules.cpp @@ -704,7 +704,11 @@ bool ModuleLinker::linkAppendingVarProto(GlobalVariable *DstGV, if (DstGV->getVisibility() != SrcGV->getVisibility()) return emitError( "Appending variables with different visibility need to be linked!"); - + + if (DstGV->hasUnnamedAddr() != SrcGV->hasUnnamedAddr()) + return emitError( + "Appending variables with different unnamed_addr need to be linked!"); + if (DstGV->getSection() != SrcGV->getSection()) return emitError( "Appending variables with different section name need to be linked!"); diff --git a/test/Linker/unnamed-addr-err-a.ll b/test/Linker/unnamed-addr-err-a.ll new file mode 100644 index 0000000000..4872098004 --- /dev/null +++ b/test/Linker/unnamed-addr-err-a.ll @@ -0,0 +1,4 @@ +; RUN: not llvm-link %s %p/unnamed-addr-err-b.ll -S -o - 2>&1 | FileCheck %s + +@foo = appending unnamed_addr global [1 x i32] [i32 42] +; CHECK: Appending variables with different unnamed_addr need to be linked diff --git a/test/Linker/unnamed-addr-err-b.ll b/test/Linker/unnamed-addr-err-b.ll new file mode 100644 index 0000000000..5e5fed9bb6 --- /dev/null +++ b/test/Linker/unnamed-addr-err-b.ll @@ -0,0 +1,4 @@ +; This file is for use with unnamed-addr-err-a.ll +; RUN: true + +@foo = appending global [1 x i32] [i32 42] |