diff options
author | Victor Hernandez <vhernandez@apple.com> | 2010-02-04 01:13:08 +0000 |
---|---|---|
committer | Victor Hernandez <vhernandez@apple.com> | 2010-02-04 01:13:08 +0000 |
commit | af6ce14d679e2a87d2de6a3e26ce6a1f34d1f879 (patch) | |
tree | 27f7c64c1cd8c519da09dcd06f60f02bebfd74d9 | |
parent | ec5ef6d8b0fcdf7bf9df397a0e3d03e1d57b6fc1 (diff) | |
download | llvm-af6ce14d679e2a87d2de6a3e26ce6a1f34d1f879.tar.gz llvm-af6ce14d679e2a87d2de6a3e26ce6a1f34d1f879.tar.bz2 llvm-af6ce14d679e2a87d2de6a3e26ce6a1f34d1f879.tar.xz |
Fix (and test) function-local metadata that occurs before the instruction that it refers to; fix is to not enumerate operands of function-local metadata until after all instructions have been enumerated
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@95269 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Bitcode/Writer/ValueEnumerator.cpp | 12 | ||||
-rw-r--r-- | test/Assembler/functionlocal-metadata.ll | 2 |
2 files changed, 10 insertions, 4 deletions
diff --git a/lib/Bitcode/Writer/ValueEnumerator.cpp b/lib/Bitcode/Writer/ValueEnumerator.cpp index c46d735e8c..3eacc5e2be 100644 --- a/lib/Bitcode/Writer/ValueEnumerator.cpp +++ b/lib/Bitcode/Writer/ValueEnumerator.cpp @@ -408,21 +408,25 @@ void ValueEnumerator::incorporateFunction(const Function &F) { FirstInstID = Values.size(); + SmallVector<MDNode *, 8> FunctionLocalMDs; // Add all of the instructions. for (Function::const_iterator BB = F.begin(), E = F.end(); BB != E; ++BB) { for (BasicBlock::const_iterator I = BB->begin(), E = BB->end(); I!=E; ++I) { for (User::const_op_iterator OI = I->op_begin(), E = I->op_end(); OI != E; ++OI) { if (MDNode *MD = dyn_cast<MDNode>(*OI)) - if (!MD->isFunctionLocal()) - // These were already enumerated during ValueEnumerator creation. - continue; - EnumerateOperandType(*OI); + if (MD->isFunctionLocal()) + // Enumerate metadata after the instructions they might refer to. + FunctionLocalMDs.push_back(MD); } if (!I->getType()->isVoidTy()) EnumerateValue(I); } } + + // Add all of the function-local metadata. + for (unsigned i = 0, e = FunctionLocalMDs.size(); i != e; ++i) + EnumerateOperandType(FunctionLocalMDs[i]); } void ValueEnumerator::purgeFunction() { diff --git a/test/Assembler/functionlocal-metadata.ll b/test/Assembler/functionlocal-metadata.ll index 16bc9d06c1..216587d98a 100644 --- a/test/Assembler/functionlocal-metadata.ll +++ b/test/Assembler/functionlocal-metadata.ll @@ -2,6 +2,8 @@ define void @Foo(i32 %a, i32 %b) { entry: + call void @llvm.dbg.value(metadata !{ i32* %1 }, i64 16, metadata !"bar") +; CHECK: call void @llvm.dbg.value(metadata !{i32* %1}, i64 16, metadata !"bar") %0 = add i32 %a, 1 ; <i32> [#uses=1] %two = add i32 %b, %0 ; <i32> [#uses=0] %1 = alloca i32 ; <i32*> [#uses=1] |