diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2012-01-30 23:47:44 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2012-01-30 23:47:44 +0000 |
| commit | beb05952ce27b4039c9d8bea929f154edeb19ca0 (patch) | |
| tree | cdbd3f07ca67008566e6882bd78aaa7c3e8ab240 | |
| parent | 893a045cdbdc08fdaa5a62a24838be2df35cb628 (diff) | |
| download | llvm-beb05952ce27b4039c9d8bea929f154edeb19ca0.tar.gz llvm-beb05952ce27b4039c9d8bea929f154edeb19ca0.tar.bz2 llvm-beb05952ce27b4039c9d8bea929f154edeb19ca0.tar.xz | |
Chris's constant data sequence refactoring actually enabled printing
vectors of all one bits to be printed more cleverly in the AsmPrinter.
Unfortunately, the byte value for all one bits is the same with
-fsigned-char as the error return of '-1'. Force this to be the unsigned
byte value when returning it to avoid this problem, and update the test
case for the shiny new behavior.
Yay for building LLVM and Clang with -funsigned-char.
Chris, please review, and let me know if there is any reason to not
desire this change. It seems good on the surface, and certainly intended
based on the code written.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149299 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 2 | ||||
| -rw-r--r-- | test/CodeGen/X86/fold-pcmpeqd-2.ll | 5 |
2 files changed, 2 insertions, 5 deletions
diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index 78f3f1d32a..1e55de4494 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -1558,7 +1558,7 @@ static int isRepeatedByteSequence(const ConstantDataSequential *V) { char C = Data[0]; for (unsigned i = 1, e = Data.size(); i != e; ++i) if (Data[i] != C) return -1; - return C; + return static_cast<uint8_t>(C); // Ensure 255 is not returned as -1. } diff --git a/test/CodeGen/X86/fold-pcmpeqd-2.ll b/test/CodeGen/X86/fold-pcmpeqd-2.ll index a7b3332cc2..9cf4607cf5 100644 --- a/test/CodeGen/X86/fold-pcmpeqd-2.ll +++ b/test/CodeGen/X86/fold-pcmpeqd-2.ll @@ -8,10 +8,7 @@ ; RAGreedy defeats the test by splitting live ranges. ; Constant pool all-ones vector: -; CHECK: .long 4294967295 -; CHECK-NEXT: .long 4294967295 -; CHECK-NEXT: .long 4294967295 -; CHECK-NEXT: .long 4294967295 +; CHECK: .space 16,255 ; No pcmpeqd instructions, everybody uses the constant pool. ; CHECK: program_1: |