diff options
| author | Kostya Serebryany <kcc@google.com> | 2011-11-23 02:10:54 +0000 |
|---|---|---|
| committer | Kostya Serebryany <kcc@google.com> | 2011-11-23 02:10:54 +0000 |
| commit | d2703dec271d82c8c9d22afb835c07730fd25d47 (patch) | |
| tree | 6911cae0c51813da4f5a1bf363f772fd1fcada65 | |
| parent | db6d211d8f71c462aee45030e46c39fcfbacbb1d (diff) | |
| download | llvm-d2703dec271d82c8c9d22afb835c07730fd25d47.tar.gz llvm-d2703dec271d82c8c9d22afb835c07730fd25d47.tar.bz2 llvm-d2703dec271d82c8c9d22afb835c07730fd25d47.tar.xz | |
[asan] do not instrument threadlocal globals, this is buggy
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@145092 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Transforms/Instrumentation/AddressSanitizer.cpp | 6 | ||||
| -rw-r--r-- | test/Instrumentation/AddressSanitizer/do-not-touch-threadlocal.ll | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/lib/Transforms/Instrumentation/AddressSanitizer.cpp b/lib/Transforms/Instrumentation/AddressSanitizer.cpp index e12da86723..b6175396d3 100644 --- a/lib/Transforms/Instrumentation/AddressSanitizer.cpp +++ b/lib/Transforms/Instrumentation/AddressSanitizer.cpp @@ -455,6 +455,11 @@ bool AddressSanitizer::insertGlobalRedzones(Module &M) { G->getLinkage() != GlobalVariable::PrivateLinkage && G->getLinkage() != GlobalVariable::InternalLinkage) continue; + // Two problems with thread-locals: + // - The address of the main thread's copy can't be computed at link-time. + // - Need to poison all copies, not just the main thread's one. + if (G->isThreadLocal()) + continue; // For now, just ignore this Alloca if the alignment is large. if (G->getAlignment() > RedzoneSize) continue; @@ -787,6 +792,7 @@ void AddressSanitizer::PoisonStack(const ArrayRef<AllocaInst*> &AllocaVec, // Workaround for bug 11395: we don't want to instrument stack in functions // with large assembly blobs (32-bit only), otherwise reg alloc may crash. +// FIXME: remove once the bug 11395 is fixed. bool AddressSanitizer::LooksLikeCodeInBug11395(Instruction *I) { if (LongSize != 32) return false; CallInst *CI = dyn_cast<CallInst>(I); diff --git a/test/Instrumentation/AddressSanitizer/do-not-touch-threadlocal.ll b/test/Instrumentation/AddressSanitizer/do-not-touch-threadlocal.ll new file mode 100644 index 0000000000..89644d4a94 --- /dev/null +++ b/test/Instrumentation/AddressSanitizer/do-not-touch-threadlocal.ll @@ -0,0 +1,6 @@ +; RUN: opt < %s -asan -S | FileCheck %s +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" +target triple = "x86_64-unknown-linux-gnu" +; no action should be taken for thread locals +@xxx = thread_local global i32 0, align 4 +; CHECK-NOT: __asan_register_globals |