diff options
author | Benjamin Kramer <benny.kra@googlemail.com> | 2013-04-21 17:48:39 +0000 |
---|---|---|
committer | Benjamin Kramer <benny.kra@googlemail.com> | 2013-04-21 17:48:39 +0000 |
commit | d81a0dee5b7df712c584e2a3e556ff2f0677e9df (patch) | |
tree | 6d20ddd17fed2dcb1e800f858d07667d0df71944 | |
parent | 54d9a3e2df7055bd4d31a18b29f37c4541653efc (diff) | |
download | llvm-d81a0dee5b7df712c584e2a3e556ff2f0677e9df.tar.gz llvm-d81a0dee5b7df712c584e2a3e556ff2f0677e9df.tar.bz2 llvm-d81a0dee5b7df712c584e2a3e556ff2f0677e9df.tar.xz |
SROA: Don't crash on a select with two identical operands.
This is an edge case that can happen if we modify a chain of multiple selects.
Update all operands in that case and remove the assert. PR15805.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@179982 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Transforms/Scalar/SROA.cpp | 16 | ||||
-rw-r--r-- | test/Transforms/SROA/basictest.ll | 11 |
2 files changed, 19 insertions, 8 deletions
diff --git a/lib/Transforms/Scalar/SROA.cpp b/lib/Transforms/Scalar/SROA.cpp index 1e18873950..c383e2f8ed 100644 --- a/lib/Transforms/Scalar/SROA.cpp +++ b/lib/Transforms/Scalar/SROA.cpp @@ -3051,16 +3051,16 @@ private: bool visitSelectInst(SelectInst &SI) { DEBUG(dbgs() << " original: " << SI << "\n"); - - // Find the operand we need to rewrite here. - bool IsTrueVal = SI.getTrueValue() == OldPtr; - if (IsTrueVal) - assert(SI.getFalseValue() != OldPtr && "Pointer is both operands!"); - else - assert(SI.getFalseValue() == OldPtr && "Pointer isn't an operand!"); + assert((SI.getTrueValue() == OldPtr || SI.getFalseValue() == OldPtr) && + "Pointer isn't an operand!"); Value *NewPtr = getAdjustedAllocaPtr(IRB, OldPtr->getType()); - SI.setOperand(IsTrueVal ? 1 : 2, NewPtr); + // Replace the operands which were using the old pointer. + if (SI.getOperand(1) == OldPtr) + SI.setOperand(1, NewPtr); + if (SI.getOperand(2) == OldPtr) + SI.setOperand(2, NewPtr); + DEBUG(dbgs() << " to: " << SI << "\n"); deleteIfTriviallyDead(OldPtr); return false; diff --git a/test/Transforms/SROA/basictest.ll b/test/Transforms/SROA/basictest.ll index 6078adead0..834032246f 100644 --- a/test/Transforms/SROA/basictest.ll +++ b/test/Transforms/SROA/basictest.ll @@ -1306,3 +1306,14 @@ end: ; CHECK: ret void } +define void @PR15805(i1 %a, i1 %b) { +; CHECK: @PR15805 +; CHECK: select i1 undef, i64* %c, i64* %c +; CHECK: ret void + + %c = alloca i64, align 8 + %p.0.c = select i1 undef, i64* %c, i64* %c + %cond.in = select i1 undef, i64* %p.0.c, i64* %c + %cond = load i64* %cond.in, align 8 + ret void +} |