summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2010-09-05 20:33:40 +0000
committerChris Lattner <sabre@nondot.org>2010-09-05 20:33:40 +0000
commitdfe254b86e93b131cceb6aa27c33b33b2c8102d6 (patch)
tree6ff4e1c25c005bc35a0cb280bc8118c43ce3d97c
parentf0f5780b39f332ac14b0d85b904126dab7c783c3 (diff)
downloadllvm-dfe254b86e93b131cceb6aa27c33b33b2c8102d6.tar.gz
llvm-dfe254b86e93b131cceb6aa27c33b33b2c8102d6.tar.bz2
llvm-dfe254b86e93b131cceb6aa27c33b33b2c8102d6.tar.xz
add a comment about where this should eventually move.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@113117 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/CodeGen/AsmPrinter/AsmPrinter.cpp7
1 files changed, 7 insertions, 0 deletions
diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index d358ab20ff..ee6d321763 100644
--- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -327,6 +327,13 @@ void AsmPrinter::EmitGlobalVariable(const GlobalVariable *GV) {
// Handle thread local data for mach-o which requires us to output an
// additional structure of data and mangle the original symbol so that we
// can reference it later.
+ //
+ // TODO: This should become an "emit thread local global" method on TLOF.
+ // All of this macho specific stuff should be sunk down into TLOFMachO and
+ // stuff like "TLSExtraDataSection" should no longer be part of the parent
+ // TLOF class. This will also make it more obvious that stuff like
+ // MCStreamer::EmitTBSSSymbol is macho specific and only called from macho
+ // specific code.
if (GVKind.isThreadLocal() && MAI->hasMachoTBSSDirective()) {
// Emit the .tbss symbol
MCSymbol *MangSym =