diff options
| author | Reid Kleckner <reid@kleckner.net> | 2014-06-25 20:25:21 +0000 |
|---|---|---|
| committer | Reid Kleckner <reid@kleckner.net> | 2014-06-25 20:25:21 +0000 |
| commit | dd4814ec92be6cae8778065196a66815b62a0450 (patch) | |
| tree | f5641d73b35dbabedf415ccffd4b5708309865c3 /docs/Phabricator.rst | |
| parent | d01f1c4054c73a184d08ed6f5817ad8de4513f3c (diff) | |
| download | llvm-dd4814ec92be6cae8778065196a66815b62a0450.tar.gz llvm-dd4814ec92be6cae8778065196a66815b62a0450.tar.bz2 llvm-dd4814ec92be6cae8778065196a66815b62a0450.tar.xz | |
Mention that Phabricator users should subscribe to *-commits
This probably explains why a lot of messages get lost for first time
Phabricator users.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@211731 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'docs/Phabricator.rst')
| -rw-r--r-- | docs/Phabricator.rst | 20 |
1 files changed, 16 insertions, 4 deletions
diff --git a/docs/Phabricator.rst b/docs/Phabricator.rst index 18b2817fc0..f5d289fc1a 100644 --- a/docs/Phabricator.rst +++ b/docs/Phabricator.rst @@ -5,18 +5,29 @@ Code Reviews with Phabricator .. contents:: :local: -If you prefer to use a web user interface for code reviews, -you can now submit your patches for Clang and LLVM at -`LLVM's Phabricator`_. +If you prefer to use a web user interface for code reviews, you can now submit +your patches for Clang and LLVM at `LLVM's Phabricator`_ instance. + +While Phabricator is a useful tool for some, the relevant -commits mailing list +is the system of record for all LLVM code review. The mailing list should be +CC'd on all reviews, and Phabricator users should be prepared to respond to +free-form comments in mail sent to the commits list. Sign up ------- +To get started with Phabricator, navigate to `http://reviews.llvm.org`_ and +click the power icon in the top right. You can register with a GitHub account, +a Google account, or you can create your own profile. + +Make *sure* that the email address registered with Phabricator is be subscribed +to the relevant -commits mailing list. If your are not subscribed to the commit +list, all mail sent by Phabricator on your behalf will be held for moderation. + Note that if you use your Subversion user name as Phabricator user name, Phabricator will automatically connect your submits to your Phabricator user in the `Code Repository Browser`_. - Requesting a review via the command line ---------------------------------------- @@ -113,6 +124,7 @@ Status Please let us know whether you like it and what could be improved! .. _LLVM's Phabricator: http://reviews.llvm.org +.. _`http://reviews.llvm.org`: http://reviews.llvm.org .. _Code Repository Browser: http://reviews.llvm.org/diffusion/ .. _Arcanist Quick Start: http://www.phabricator.com/docs/phabricator/article/Arcanist_Quick_Start.html .. _Arcanist User Guide: http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html |