diff options
| author | Owen Anderson <resistor@mac.com> | 2010-08-11 22:36:04 +0000 |
|---|---|---|
| committer | Owen Anderson <resistor@mac.com> | 2010-08-11 22:36:04 +0000 |
| commit | cf6abd248672486bf037c8b74d4a779be6d5688a (patch) | |
| tree | 19607ac88f6dac913bcb44bc69635244df6f36fb /lib/Analysis/LazyValueInfo.cpp | |
| parent | 7f9ef4bb514d5a28637789d8f397dadd4344dc1b (diff) | |
| download | llvm-cf6abd248672486bf037c8b74d4a779be6d5688a.tar.gz llvm-cf6abd248672486bf037c8b74d4a779be6d5688a.tar.bz2 llvm-cf6abd248672486bf037c8b74d4a779be6d5688a.tar.xz | |
Fix a subtle use-after-free issue.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@110863 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/LazyValueInfo.cpp')
| -rw-r--r-- | lib/Analysis/LazyValueInfo.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/Analysis/LazyValueInfo.cpp b/lib/Analysis/LazyValueInfo.cpp index c932e81e24..d3a437f940 100644 --- a/lib/Analysis/LazyValueInfo.cpp +++ b/lib/Analysis/LazyValueInfo.cpp @@ -384,7 +384,6 @@ namespace { } // end anonymous namespace void LazyValueInfoCache::LVIValueHandle::deleted() { - Parent->ValueCache.erase(*this); for (std::set<std::pair<BasicBlock*, Value*> >::iterator I = Parent->OverDefinedCache.begin(), E = Parent->OverDefinedCache.end(); @@ -394,6 +393,10 @@ void LazyValueInfoCache::LVIValueHandle::deleted() { if (tmp->second == getValPtr()) Parent->OverDefinedCache.erase(tmp); } + + // This erasure deallocates *this, so it MUST happen after we're done + // using any and all members of *this. + Parent->ValueCache.erase(*this); } |